1.9.0 <- 1.8.0 Sync #476
1.9.0 <- 1.8.0 Sync #476
Conversation
CRDCDH-2053 Updated user guide pdf
C3DC 2068
added study id to genetic analysis table downloads
C3DC-2090 fixed survival and treatment id columns
There was a problem hiding this comment.
Pull request overview
This PR syncs bugfixes and documentation updates from the pending 1.8.0 release branch into the 1.9.0 future release branch. The changes primarily focus on correcting figure references in user guide documentation, fixing data field identifiers in dashboard configuration, and updating documentation file references.
Changes:
- Updated figure numbering throughout user guide sections to maintain sequential consistency
- Corrected data field identifiers in dashboard tab configuration (
treatment_idandsurvival_id) - Updated release notes and user guide file references to newer versions
Reviewed changes
Copilot reviewed 7 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| StudyMetadataSection.js | Updated figure references from Figure 5 to Figure 6 and corrected image import |
| OverviewSection.js | Minor grammar and formatting corrections in user guide text |
| FindDataSection.js | Added Figure 4 for column customization and renumbered subsequent figures; updated study data description |
| CohortSection.js | Renumbered figures from 6-8 to 7-9 and updated all figure references throughout |
| AnalyzingCohortsSection.js | Renumbered figures from 9-10 to 10-11 and simplified CCDI Hub reference |
| dashboardTabData.js | Added study_id field to genetic analysis query and corrected field names for treatment and survival IDs |
| aboutPageData.js | Updated file references to newer versions of release notes and user guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| numbers of diagnoses, participants, and studies filtered (Figure 1E). | ||
| Users can also build synthetic cohort (up to 4000 participants each | ||
| the data table (Figure 1D). A statistics bar at the top reflects current | ||
| numbers of diagnoses, participants and studies filtered (Figure 1E). |
There was a problem hiding this comment.
Removed the Oxford comma before 'and studies'. For consistency, consider using the Oxford comma (comma before 'and' in a list of three or more items) throughout the documentation if it's the project's style guide.
| numbers of diagnoses, participants and studies filtered (Figure 1E). | |
| numbers of diagnoses, participants, and studies filtered (Figure 1E). |
| }, | ||
| { | ||
| dataField: "id", | ||
| dataField: "treatment_id", |
There was a problem hiding this comment.
Changed from 'id' to 'treatment_id'. Ensure the data source provides this field name, as mismatched field names will cause the table to display undefined or missing data.
| }, | ||
| { | ||
| dataField: "id", | ||
| dataField: "survival_id", |
There was a problem hiding this comment.
Changed from 'id' to 'survival_id' in the treatmentResponseTab configuration, but the header indicates this is for 'Survival ID'. This appears to be in the wrong tab section - survival_id is being set in treatmentResponseTab rather than survivalTab, which could cause data display issues.
| dataField: "survival_id", | |
| dataField: "id", |
Syncing the new 1.9.0 future release branch with the last few bugfixes from the pending 1.8.0 release