C3DC-2030 #1185
C3DC-2030 #1185
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the local find item removal functionality to properly identify items using both title and type properties. Previously, items were filtered by title only, which could cause issues when multiple items share the same title but have different types (e.g., synonyms vs. main items).
Changes:
- Updated
deleteWrapperandonDeletefunctions to accept both title and type parameters - Modified the filter logic to check both
titleandtypeproperties when removing items - Bumped package version from 1.0.0-c3dc.5 to 1.0.0-c3dc.6
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/local-find/src/SearchBox/components/SearchList.js | Updated deleteWrapper to accept both title and type, and passed item.type to the delete handler |
| packages/local-find/src/SearchBox/SearchBoxGenerator.js | Updated onDelete function to filter items by both title and type properties |
| packages/local-find/package.json | Version bump to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } = props; | ||
|
|
||
| const deleteWrapper = (item) => { | ||
| const deleteWrapper = (item, fullvalue) => { |
There was a problem hiding this comment.
The parameter name 'fullvalue' is inconsistent with the actual value being passed ('item.type'). Consider renaming this parameter to 'type' to match the JSDoc in SearchBoxGenerator.js and improve code clarity.
Fix local find item removal to use both title and type for filtering
Summary
Updated the local find search functionality to properly identify and remove items by checking both title and type properties instead of just title. This ensures accurate item removal, particularly when dealing with items that might have similar titles but different types (e.g., synonyms vs. main items).