INS-1517, Design 508 Fixes #1188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses 508 accessibility compliance issues in the bento library by adding proper ARIA labels and attributes to various input components, checkboxes, pagination controls, and search elements.
Changes:
- Added ARIA labels to checkboxes in table headers, rows, and column management views
- Enhanced pagination controls with proper ARIA labels for page navigation
- Added ARIA labels to search input fields and text areas
- Improved slider accessibility with ARIA labels for min/max thumbs and inputs
- Updated version numbers for modified packages
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/table/src/toolbar/ManageColumnView.js | Added aria-label to column selection checkbox |
| packages/table/src/pagination/CustomPagination.js | Added aria-label and labelledby to rows-per-page selector |
| packages/table/src/header/components/CheckBoxView.js | Added aria-label to select-all checkbox |
| packages/table/src/body/components/CheckBoxView.js | Added aria-label to row selection checkbox |
| packages/table/package.json | Version bump to 1.0.1-ins.29 |
| packages/paginated-table/src/wrapper/components/TextFieldView.js | Added aria-label prop and attribute to text field |
| packages/paginated-table/package.json | Version bump to 1.0.1-ins.31 |
| packages/local-find/src/SearchBox/config.js | Added default ariaLabel to search config |
| packages/local-find/src/SearchBox/SearchBoxGenerator.js | Implemented aria-label support for search input |
| packages/local-find/package.json | Version bump to 1.0.1-ins.4 |
| packages/global-search/src/SearchResults/components/PaginatedPanel.js | Added aria-labels to pagination buttons and corrected alt text |
| packages/global-search/src/SearchBar/config.js | Added default ariaLabel to search config |
| packages/global-search/src/SearchBar/components/CustomTextField.js | Added aria-label support to search field |
| packages/global-search/src/SearchBar/SearchBarGenerator.js | Extracted placeholder and ariaLabel configuration |
| packages/global-search/package.json | Version bump to 1.0.1-ins.13 |
| packages/facet-filter/src/components/inputs/slider/SliderView.js | Added aria-label for slider thumbs |
| packages/facet-filter/src/components/inputs/slider/InputMinMaxView.js | Added aria-label to min/max input fields |
| packages/facet-filter/src/components/inputs/checkbox/CheckboxView.js | Enhanced checkbox accessibility with proper tabIndex and aria attributes |
| packages/facet-filter/package.json | Version bump to 1.0.1-ins.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some 508 issues that need to be resolved in the bento library, notably the aria labels for certain input components.
This previous PR for GC was used as a referenced when creating this PR
#1016
#1017
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # INS-1517
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally