Skip to content

Conversation

@MukjepScarlet
Copy link
Contributor

No description provided.

@MukjepScarlet MukjepScarlet added this to the 0.35.2 milestone Nov 30, 2025
@MukjepScarlet MukjepScarlet self-assigned this Nov 30, 2025
@MukjepScarlet MukjepScarlet marked this pull request as draft November 30, 2025 07:25
@MukjepScarlet MukjepScarlet changed the title feat: SoundInstanceEvent & HUD subtitles tweak feat(HUD): subtitles Nov 30, 2025
@MukjepScarlet MukjepScarlet requested a review from SenkJu November 30, 2025 09:28
@MukjepScarlet MukjepScarlet marked this pull request as ready for review November 30, 2025 09:28
@SenkJu
Copy link
Contributor

SenkJu commented Dec 3, 2025

I think this is all right but the behavior seems to be different from Vanilla subtitles. It seems like subtitles are not properly removed from the list? They at least stick around a lot longer.

@MukjepScarlet
Copy link
Contributor Author

Probably because of the event.

@MukjepScarlet
Copy link
Contributor Author

@SenkJu fixed by sending filtered list. You can disable the tweak and compare them.

@1zun4 1zun4 modified the milestones: 0.35.2, 0.36.0 Dec 7, 2025
@SenkJu
Copy link
Contributor

SenkJu commented Dec 7, 2025

There still seem to be issues. Compare the vanilla implementation against yours. The direction arrow does not seem to work properly. Also, often times, sounds will never be added to the list.

Edit: I think all of the math you are currently doing in the frontend should be done in the client. Prepare the data so that it only needs to be displayed. This should be much easier than replicating the game's behavior in the UI since you can use the exact methods the Vanilla implementation uses.

@MukjepScarlet
Copy link
Contributor Author

If I 1:1 copy Java logic at Kotlin side then other theme designers will not be able to use "custom" (or hacky) info, for example someone want to make a PointerESP-like indicators for sounds, the left-right info is not enough.

@MukjepScarlet MukjepScarlet modified the milestones: 0.36.0, 0.37.0 Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants