fix(build): decouple WITH_FFMPEG from ENABLE_HARDSUBX, fix FFmpeg 5.0+ API

[cfsmp3]

Summary

• Remove ENABLE_HARDSUBX from WITH_FFMPEG CMake blocks — hardsubx should only be enabled by WITH_HARDSUBX, not implied by FFmpeg
• WITH_HARDSUBX now auto-enables WITH_OCR and WITH_FFMPEG (it requires both)
• Fix const AVCodec* in ffmpeg_intgr.c for FFmpeg 5.0+ API compatibility

Background

Since 2017 (commit 4f5f564b), WITH_FFMPEG=ON automatically defined ENABLE_HARDSUBX. At that time there was no separate WITH_HARDSUBX option — FFmpeg and hardsubx were the same thing. In 2018 (PR #966), WITH_HARDSUBX was added as a separate option but the old coupling was never removed. This made -DWITH_FFMPEG=ON fail because it compiled hardsubx code without linking tesseract/leptonica.

Test plan

All 7 build combinations tested:

#	Flags	Before	After
1	Default	OK	OK
2	WITH_FFMPEG	FAILS	OK
3	WITH_HARDSUBX + WITH_OCR	OK	OK
4	WITH_FFMPEG + WITH_HARDSUBX + WITH_OCR	FAILS	OK
5	WITH_FFMPEG + WITH_OCR	FAILS	OK
6	WITH_OCR	OK	OK
7	WITH_HARDSUBX only	FAILS	OK

Default build regression test: output byte-identical to master.

🤖 Generated with Claude Code

[ccextractor-bot]

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5fdd9b8...:

Report Name	Tests Passed
Broken	9/13
CEA-708	1/14
DVB	3/7
DVD	3/3
DVR-MS	2/2
General	16/27
Hardsubx	1/1
Hauppage	3/3
MP4	1/3
NoCC	10/10
Options	77/86
Teletext	19/21
WTV	11/13
XDS	30/34

Your PR breaks these cases:

• ccextractor --autoprogram --out=ttxt --latin1 9a496d3828...
• ccextractor --autoprogram --out=ttxt --latin1 1974a299f0...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad...
• ccextractor --in=mp4 --out=srt --latin1 b2771c84c2...
• ccextractor --autoprogram --out=srt --bom --latin1 8849331dda...
• ccextractor --autoprogram --out=ttxt --latin1 efbe129086...
• ccextractor --out=srt --latin1 d7e7dbdf68...
• ccextractor --out=srt --latin1 76734ac4a7...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455...

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed:

  Test 8738

• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed:

  Test 9176

• ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed:

  Test 8738

• ccextractor --out=srt --latin1 4d4e938ef6..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt 80848c45f8..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1 --out=srt da904de35d..., Last passed:

  Test 8738

• ccextractor --service 1 --out=sami da904de35d..., Last passed:

  Test 8738

• ccextractor --service 1 --out=ttxt da904de35d..., Last passed:

  Test 8926

• ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service all da904de35d..., Last passed:

  Test 8738

• ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed:

  Test 8738

• ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed:

  Test 8738

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Test 8738

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Test 8738

• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed:

  Test 9176

• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed:

  Test 9176

• ccextractor --service 1 c83f765c66..., Last passed:

  Test 8738

• ccextractor --out=spupng c83f765c66..., Last passed:

  Test 9176

• ccextractor --myth c83f765c66..., Last passed:

  Test 8738

• ccextractor --in=raw fb79021542..., Last passed:

  Test 8738

• ccextractor --mp4vidtrack 5df914ce77..., Last passed:

  Test 8738

• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed:

  Test 9176

• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed:

  Test 9176

• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed:

  Test 9176

• ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed:

  Test 8738

• ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed:

  Test 8738

• ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed:

  Test 9176

• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed:

  Test 9176

Congratulations: Merging this PR would fix the following tests:

• ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Never
• ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Never

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 395f9b3...:

Report Name	Tests Passed
Broken	9/13
CEA-708	1/14
DVB	4/7
DVD	3/3
DVR-MS	2/2
General	22/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	80/86
Teletext	20/21
WTV	13/13
XDS	31/34

Your PR breaks these cases:

• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b...
• ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9...
• ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc...
• ccextractor --autoprogram --out=srt --latin1 b22260d065...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e...
• ccextractor --autoprogram --out=ttxt --latin1 01509e4d27...
• ccextractor --parsePMT --out=srt c83f765c66...
• ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e...
• ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7...

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed:

  Test 8611

• ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed:

  Test 8611

• ccextractor --out=srt --latin1 4d4e938ef6..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt 80848c45f8..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1 --out=srt da904de35d..., Last passed:

  Test 8611

• ccextractor --service 1 --out=sami da904de35d..., Last passed:

  Test 8611

• ccextractor --service 1 --out=ttxt da904de35d..., Last passed:

  Test 8943

• ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service all da904de35d..., Last passed:

  Test 8611

• ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed:

  Test 8611

• ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed:

  Test 8611

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Test 8611

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Test 8611

• ccextractor --service 1 c83f765c66..., Last passed:

  Test 8611

• ccextractor --myth c83f765c66..., Last passed:

  Test 8611

• ccextractor --in=raw fb79021542..., Last passed:

  Test 8611

• ccextractor --mp4vidtrack 5df914ce77..., Last passed:

  Test 8611

• ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed:

  Test 8611

• ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed:

  Test 8611

Congratulations: Merging this PR would fix the following tests:

• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Never
• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Never
• ccextractor --out=spupng c83f765c66..., Last passed: Never
• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.