Skip to content

Fix: button overflow in Select Directory #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mulikruchi07 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: button overflow in Select Directory #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
262 changes: 140 additions & 122 deletions lib/app/modules/settings/views/settings_page_select_directory_list_tile.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ class SettingsPageSelectDirectoryListTile extends StatelessWidget {

@override
Widget build(BuildContext context) {
TaskwarriorColorTheme tColors = Theme.of(context).extension<TaskwarriorColorTheme>()!;
TaskwarriorColorTheme tColors =
Theme.of(context).extension<TaskwarriorColorTheme>()!;
return ListTile(
title: Text(
SentenceManager(currentLanguage: AppSettings.selectedLanguage)
Expand All @@ -51,148 +52,165 @@ class SettingsPageSelectDirectoryListTile extends StatelessWidget {
const SizedBox(
height: 10,
),
Row(
children: [
//Reset to default
TextButton(
style: ButtonStyle(
backgroundColor: WidgetStateProperty.all<Color>(
tColors.secondaryBackgroundColor!,
),
),
onPressed: () async {
if (await controller.getBaseDirectory() == "Default") {
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
content: Text(
SentenceManager(
currentLanguage: AppSettings.selectedLanguage)
.sentences
.settingsAlreadyDefault,
style: TextStyle(
color: tColors.primaryTextColor,
),
),
backgroundColor: tColors.secondaryBackgroundColor,
duration: const Duration(seconds: 2)));
} else {
showDialog(
context: context,
builder: (BuildContext context) {
return Utils.showAlertDialog(
title: Text(
SentenceManager(
currentLanguage:
AppSettings.selectedLanguage)
.sentences
.settingsResetToDefault,
style: GoogleFonts.poppins(
fontWeight: FontWeight.bold,
fontSize: TaskWarriorFonts.fontSizeMedium,
color: tColors.primaryTextColor,
),
),
content: Text(
SentenceManager(
currentLanguage:
AppSettings.selectedLanguage)
.sentences
.settingsConfirmReset,
style: GoogleFonts.poppins(
color: TaskWarriorColors.grey,
fontSize: TaskWarriorFonts.fontSizeMedium,
IntrinsicHeight(
child: Row(
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
// Reset to Default Button
Expanded(
child: TextButton(
style: ButtonStyle(
backgroundColor: WidgetStateProperty.all<Color>(
tColors.secondaryBackgroundColor!,
),
),
onPressed: () async {
if (await controller.getBaseDirectory() == "Default") {
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
content: Text(
SentenceManager(
currentLanguage:
AppSettings.selectedLanguage)
.sentences
.settingsAlreadyDefault,
style: TextStyle(
color: tColors.primaryTextColor,
),
),
),
actions: [
TextButton(
onPressed: () {
Navigator.pop(context);
},
child: Text(
backgroundColor: tColors.secondaryBackgroundColor,
duration: const Duration(seconds: 2)));
} else {
showDialog(
context: context,
builder: (BuildContext context) {
return Utils.showAlertDialog(
title: Text(
SentenceManager(
currentLanguage:
AppSettings.selectedLanguage)
.sentences
.settingsNoButton,
.settingsResetToDefault,
style: GoogleFonts.poppins(
fontWeight: FontWeight.bold,
fontSize: TaskWarriorFonts.fontSizeMedium,
color: tColors.primaryTextColor,
),
),
),
TextButton(
onPressed: () async {
Navigator.pop(context);
controller.isMovingDirectory.value = true;

// InheritedProfiles profilesWidget =
// ProfilesWidget.of(context);
var profilesWidget =
Get.find<SplashController>();

Directory source =
profilesWidget.baseDirectory();
Directory destination =
await profilesWidget.getDefaultDirectory();
controller
.moveDirectory(
source.path, destination.path)
.then((value) async {
profilesWidget.setBaseDirectory(destination);
SharedPreferences prefs =
await SharedPreferences.getInstance();
await prefs.remove('baseDirectory');
controller.isMovingDirectory.value = false;
controller.baseDirectory.value = "Default";
});
},
child: Text(
content: Text(
SentenceManager(
currentLanguage:
AppSettings.selectedLanguage)
.sentences
.settingsYesButton,
.settingsConfirmReset,
style: GoogleFonts.poppins(
color: tColors.primaryTextColor,
color: TaskWarriorColors.grey,
fontSize: TaskWarriorFonts.fontSizeMedium,
),
),
),
],
actions: [
TextButton(
onPressed: () {
Navigator.pop(context);
},
child: Text(
SentenceManager(
currentLanguage:
AppSettings.selectedLanguage)
.sentences
.settingsNoButton,
style: GoogleFonts.poppins(
color: tColors.primaryTextColor,
),
),
),
TextButton(
onPressed: () async {
Navigator.pop(context);
controller.isMovingDirectory.value = true;

// InheritedProfiles profilesWidget =
// ProfilesWidget.of(context);
var profilesWidget =
Get.find<SplashController>();

Directory source =
profilesWidget.baseDirectory();
Directory destination = await profilesWidget
.getDefaultDirectory();
controller
.moveDirectory(
source.path, destination.path)
.then((value) async {
profilesWidget
.setBaseDirectory(destination);
SharedPreferences prefs =
await SharedPreferences.getInstance();
await prefs.remove('baseDirectory');
controller.isMovingDirectory.value =
false;
controller.baseDirectory.value =
"Default";
});
},
child: Text(
SentenceManager(
currentLanguage:
AppSettings.selectedLanguage)
.sentences
.settingsYesButton,
style: GoogleFonts.poppins(
color: tColors.primaryTextColor,
),
),
),
],
);
},
);
},
);
}
},
child: Text(
SentenceManager(
currentLanguage: controller.selectedLanguage.value)
.sentences
.settingsPageSetToDefault,
style: TextStyle(
color: tColors.purpleShade,
}
},
child: Text(
SentenceManager(
currentLanguage:
controller.selectedLanguage.value)
.sentences
.settingsPageSetToDefault,
textAlign: TextAlign.center,
softWrap: true,
maxLines: 2,
style: TextStyle(
color: tColors.purpleShade,
),
),
Comment on lines +172 to +184
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first button's Text widget is missing the overflow property, which is inconsistent with the second button at line 207. For consistency and to ensure proper text overflow behavior when translations are long, both buttons should have the same overflow handling. Consider adding overflow: TextOverflow.visible, after maxLines: 2, on line 180.

Copilot uses AI. Check for mistakes.
),
),
),
const Spacer(),
//Change directory
TextButton(
style: ButtonStyle(
backgroundColor: WidgetStateProperty.all<Color>(
tColors.secondaryBackgroundColor!,
),
),
onPressed: () {
controller.pickDirectory(context);
},
child: Text(
SentenceManager(
currentLanguage: controller.selectedLanguage.value)
.sentences
.settingsPageChangeDirectory,
style: TextStyle(
color: tColors.purpleShade,
const SizedBox(width: 10),

// Change Directory Button
Expanded(
child: TextButton(
style: ButtonStyle(
backgroundColor: WidgetStateProperty.all<Color>(
tColors.secondaryBackgroundColor!,
),
),
onPressed: () => controller.pickDirectory(context),
child: Text(
SentenceManager(
currentLanguage:
controller.selectedLanguage.value)
.sentences
.settingsPageChangeDirectory,
textAlign: TextAlign.center,
softWrap: true,
maxLines: 2,
overflow: TextOverflow.visible,
style: TextStyle(color: tColors.purpleShade),
),
),
),
),
],
],
),
),
],
),
Expand Down