Added nonbillable cluster list to billable processor#196
Merged
Conversation
naved001
reviewed
May 15, 2025
As we plan to process projects from the non-billable `ocp-test` cluster [1], a list is added containing just `ocp-test`. This list is also used by the Coldfront processor when validating the Coldfront API data. As processing now has cluster-specific processing, a new column `Cluster Name` is added. Test cases have been updated accordingly. While revising test cases, two bugs were found: - In `TestColdfrontFetchProcessor._get_test_invoice`, the default value for project names was set to be a copy of project ids. This didn’t invalidate pre-existing test cases, but would have invalidated the test that checked for nonbillable clusters. - in `TestValidateBillablePIProcessor.test_remove_nonbillables`, in the last assertion which checked if the output invoice only contained billable PIs, the assertion only checked if the invoice contained PIs from the list, not if the invoice ALL PIs from it, and with an exact quantity. This bug does invalidate the test. Fortunately, test cases still passed after the bug is fixed. [1] CCI-MOC#167
QuanMPhm
force-pushed
the
enhancement/nonbillable
branch
from
dcff11e to
9518e4b
Compare
naved001
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #165. More details in the commit message. This is blocking #167 and #152.
I have a feeling this solution for the
ocp-testdebacle is a bit clunky. Let me know what you guys think.