Chromium test is not a unit test#219
Merged
Merged
Conversation
QuanMPhm
reviewed
Jul 15, 2025
larsks
force-pushed
the
fix/chromium-test
branch
2 times, most recently
from
754d8cf to
4d25aa5
Compare
Relocate tests/unit/test_chromium.py to tests/integration/test_chromium.py. The chromium test is not a unit test -- it has an external dependency on Chromium. By relocating it to tests/integration, we ensure that the unit tests run without errors. This commit also contains some minor changes to suppress warnings from strict type checkers.
larsks
force-pushed
the
fix/chromium-test
branch
from
4d25aa5 to
98091fb
Compare
QuanMPhm
approved these changes
Jul 15, 2025
Contributor
naved001
approved these changes
Jul 15, 2025
The chrome binary used for pdf generation is controlled by the CHROME_BIN_PATH environment variable, but the test in in process_report/tests/integration/test_chromium.py expected the literal path `/usr/bin/chromium`. This would cause the tests to fail if run in an environment in which chromium was not installed, even if the code successfully used an alternate path.
larsks
force-pushed
the
fix/chromium-test
branch
from
98091fb to
723d223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocate tests/unit/test_chromium.py to tests/integration/test_chromium.py.
The chromium test is not a unit test -- it has an external dependency on
Chromium. By relocating it to tests/integration, we ensure that the unit
tests run without errors.
This commit also contains some minor changes to suppress warnings from
strict type checkers.