Projects that belong to courses are now non-billable#240
Merged
Conversation
Contributor
Author
|
@joachimweyl @knikolla @naved001 I've updated this PR to make courses only nonbillable if |
naved001
reviewed
Nov 3, 2025
knikolla
reviewed
Nov 3, 2025
Contributor
Author
knikolla
approved these changes
Nov 25, 2025
Contributor
|
@QuanMPhm do we know what the conflicts are that need to be resolved? |
Contributor
Author
|
@joachimweyl I see that this PR is now relevant to the Iceberg project. I'll resolve the conflicts today |
QuanMPhm
force-pushed
the
is_course
branch
2 times, most recently
from
1524272 to
9f092e9
Compare
Contributor
Author
|
@naved001 Would like your approval |
naved001
approved these changes
Feb 23, 2026
| ): | ||
| institute_list = util.load_institute_list() | ||
|
|
||
| print(data) |
Collaborator
There was a problem hiding this comment.
probably meant for debugging, right? can be removed now.
knikolla
requested changes
Feb 26, 2026
knikolla
left a comment
knikolla
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Remove print statement mentioned in comment.
Leveraging the private field `Is Course?` in Coldfront [1], if this field is set to `Yes`, the project/allocation is considered part of a course. For now, any project that is a part of a course and belongs to Boston University is non-billable. [2] If the field is not set, it's assumed to be not part of a course [1] https://github.com/ubccr/coldfront/blob/a4b6b4c1d18535f61de5aa4bbfe509d7d8ca4b0f/coldfront/core/allocation/management/commands/add_allocation_defaults.py#L56 [2] CCI-MOC/invoicing-private-data#66 (comment)
- Moved functions related to `InstituteList` into the class
knikolla
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/CCI-MOC/non-billable-projects/issues/66. Leveraging the private field
Is Course?in Coldfront [1], if this field is set toYes, the project/allocation is considered part of a course and therefore non-billable.If the field is not set, it's assumed to be not part of a course
[1] https://github.com/ubccr/coldfront/blob/a4b6b4c1d18535f61de5aa4bbfe509d7d8ca4b0f/coldfront/core/allocation/management/commands/add_allocation_defaults.py#L56