Fixed CI failure#257
Merged
Merged
Conversation
knikolla
reviewed
Jan 27, 2026
While not entire clear, it seems the recent Pandas relase (3.0.0) changed how casting to decimal types works, generally making many operations more strict. This caused some tests to fail. Seperating loading of the CSV and casting seems to fix this. A more rigorous review of how types are handled through the codebase may be needed in the future.
Contributor
Author
|
@knikolla I've amended the PR |
knikolla
approved these changes
Jan 29, 2026
jimmysway
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While not entirely clear, it seems the recent Pandas relase (3.0.0) changed how casting to decimal types works, causing some invoicing code to throw errors, specifically calls to
read_csv()Seperating loading of the CSV and casting seems to fix this