Use coverage to measure code coverage in unit and e2e tests#302
Merged
Conversation
Also set minimum coverage thresholds
larsks
reviewed
Jun 2, 2026
Comment on lines
+32
to
+34
| coverage run --source="." -m pytest process_report/tests/e2e/test_e2e_pipeline.py -v -s --log-cli-level=INFO | ||
| coverage combine | ||
| coverage html --fail-under=85 --omit "process_report/tests/**,process_report/util.py,process_report/institute_list_validate.py" |
Member
There was a problem hiding this comment.
Rather than running coverage explicitly, you can install the pytest-cov plugin to have coverage run as part of your pytest invocation.
Contributor
Author
There was a problem hiding this comment.
I'm having trouble trying to get pytest-cov to properly cover the e2e test. It is not covering the subprocess created during the test. I'll just merge this PR as it is for now. I may look at using pytest-cov in the future
larsks
approved these changes
Jun 2, 2026
knikolla
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #185. I've added usage of
coveragewith minimum coverage goals. I expect these goals to be increased after we merge in the unit tests that @marcoagonzales007 is writing for the mentioned issue.