Increase e2e coverage for NewPICredit and Prepayment processors#308
Increase e2e coverage for NewPICredit and Prepayment processors#308marcoagonzales007 wants to merge 3 commits into
Conversation
| pi4@example.edu,2025-06,0.00,0.00,0.00 | ||
| pi1@bu.edu,2025-04,1000.00,300.00,0.00 | ||
| pi2@harvard.edu,2025-04,1000.00,300.00,0.00 | ||
| pi1@bu.edu,2025-06,1000.00,320.00,0.00 |
There was a problem hiding this comment.
Based on your PR description and the changes you made, it seems that since the e2e test will now actually apply the New-PI credit and prepayments to some invoices, mutable test files (test_PI.csv and test_prepay_debits.py) will now be changed after each run of the e2e test. Could you edit the code in test_e2e_pipeline.py so that the aforementioned files are not changed after each run? My suggestion comes from the idea that what we commit into the repo should only be the test cases, not their results or side effects. Investigate the ways you can accomplish this, and let me know what solution you'll like to implement.
Also, I'm curious why I don't see changes to test_prepay_debits.py in this PR diff. Was it not changed when you ran the e2e test on your machine?
There was a problem hiding this comment.
Thank you for your feedback, and I think It was changed by the pipeline itself during the run. I reverted it thinking it was a stray change, but I now realize that's the side effect of the problem you have just described. I'll work on test_e2e_pipeline.py so that the files are not changed after each run. my plan for this is to copy the mutable files into the temp workspace and point the pipeline at these copies, so the test data stays untouched. Let me know if that sounds good. Thank you.
There was a problem hiding this comment.
I'll work on test_e2e_pipeline.py so that the files are not changed after each run. my plan for this is to copy the mutable files into the temp workspace and point the pipeline at these copies,
Nice! That was the solution I had in mind too. Let me know when you've amended this PR.
Part of #185
Updates the e2e test data so the full pipeline covers previously-uncovered branches in the two processors
NewPICreditProcessor(80% -> 90%)test_PI.csvPrepaymentProcessor(82% -> 87%)