Switch to Ruff from Black for formatting and linting#97
Conversation
| - repo: https://github.com/psf/black | ||
| rev: 24.4.0 | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: v0.2.1 |
There was a problem hiding this comment.
Can you use a more updated version of ruff? From their repo, is seems the latest is v11.
In fact, feel free to make a Dependabot PR as well (similar to this) so we won't need to be concerned about this. Please still update the version here though
There was a problem hiding this comment.
Sounds good. If we need to update this one, we'll need to update the invoicing ruff as well since this is pulled exactly from that.
We can move on from black pre-commit hook with ruff-format for better performance and the ability to point out unused imports.
KelvinLinBU
force-pushed
the
precommit-update
branch
from
43da16b to
906f014
Compare
| if not dump_file: | ||
| raise Exception( | ||
| "Must provide either --sql_dump_file" "or --download_dump_from_s3." | ||
| "Must provide either --sql_dump_fileor --download_dump_from_s3." |
There was a problem hiding this comment.
Not requesting a change to this PR, but it's funny that the linter caught a typo here. Feel free to make another PR to fix this typo
There was a problem hiding this comment.
The linter is paying dividends already haha. I'll make a pr to fix the small typo once this is merged.
|
@knikolla This is ready for your review. |
3 participants
Closes #96. Switch from black to ruff-format as a pre-commit hook since it offers better performance and the groundwork for future linting enhancements like unused import detection and cleanup.