Skip to content

Changes from Debangsu for Aspen V14 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ksbeattie
Copy link
Member

@ksbeattie ksbeattie commented Feb 4, 2025

This PR fixes issue #9 and replaces PR #10.

Files from Debangsu:
Please find attached the updated ACM files CompIG and teg4dyn that goes under Commpressor/Dynamic/ and also the ACM file that goes under Dynamic/Example_Flowrate/. Also please place the attached teg4dyn file also in under Dynamic/Example_Flowrate/ folder. I have also updated the manual with the updated results.

Keith's changes:
Updated license, copyright dates and version in word doc and regenerated PDF version.

@ksbeattie ksbeattie requested a review from jmorgan29 February 4, 2025 22:53
@ksbeattie ksbeattie self-assigned this Feb 4, 2025
@ksbeattie ksbeattie added the bug label Feb 4, 2025
@ksbeattie ksbeattie linked an issue Feb 4, 2025 that may be closed by this pull request
@ksbeattie
Copy link
Member Author

@jmorgan29 I think you were going to try and run through this? Any progress?

@dhumbird
Copy link

This simulation can now be opened in V14, but the properties are again included as a binary appdf file, which won't be compatible with future versions. (I'm usually on V14.5 but I happen to have V14 installed this week.) Like I indicated in the PR, the aprbkp files are needed--or the properties can be embedded, which functionally concatenates the aprbkp to the acmf file as text.

If helpful, I can take care of the embed while I can open the simulation.

@dhumbird
Copy link

I was not able to reproduce the properties from the binary. I substituted what I thought were the correct properties, but then the model didn't converge. There must be some customizations in the original. This example needs its .aprbkp for completeness--the .appdf can always be regenerated from that.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.aprbkp files are needed for upward compatibility
2 participants