-
Notifications
You must be signed in to change notification settings - Fork 8
Multidiags mp #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
painter1
wants to merge
26
commits into
master
Choose a base branch
from
multidiags-mp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multidiags mp #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work in Python >=3.4.
…or model,obs,output) - because os.path.exists() doesn't understand '~' in a path.
…sses have to be run in a shell with Popen(). Communication is done with a temporary file and through the stdout pipe. There remains some non-functional commented-out code to do this other ways (which would be better is spawning, rather than forking, were allowed those ways.)
… the number of processes to be run simultaneously. For now, the maximum is hard-coded.
…or Popen, it pickles its Options object to a string, which is passed to diags.py in the shell command line.
…g code, which is no more than a function call.
…ether its file format matches the rest.
…ames. It makes the filenames more repeatable, but would require us to change the present ctest baselines.
…d for use in the NetCDF file's name. In the write_plot_data method, getting the axis of zax, do it whether zax is a variable or tuple of variables.
…Do both; previously only one was supported.
… multiprocessing.
…ential for testing.
…rect values of some essential options.
… use instead of stdout.
…omparison of an Options instance for collection 7s as generated by metadiags and multidiags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a multiprocessing capability to multidiags.py.
Also it has new tests: one of multidiags itself, and one comparing metadiags to multidiags.