Fix coloring

jayb · jayb · commit 46f8a1750196 · 2026-03-30T12:43:41.000-04:00
diff --git a/packages/waffle-chart/src/CdcWaffleChart.tsx b/packages/waffle-chart/src/CdcWaffleChart.tsx
@@ -500,8 +500,8 @@ const WaffleChart = ({ config, isEditor, link = '', showConfigConfirm, updateCon
         x: calculatePos(shape, 'x', i, nodeWidthNum, nodeSpacerNum, columns, rows),
         y: calculatePos(shape, 'y', i, nodeWidthNum, nodeSpacerNum, columns, rows),
         color: config.visual.colors[theme],
-        opacity: i + 1 > 100 - Math.round(Number(dataPercentage)) ? 1 : 0.2,
-        isFilled: i + 1 > 100 - Math.round(Number(dataPercentage))
+        opacity: isFilled ? 1 : 0.2,
+        isFilled: isFilled
       }
       waffleData.push(newNode)
     }

Original file line number	Diff line number	Diff line change
`@@ -500,8 +500,8 @@ const WaffleChart = ({ config, isEditor, link = '', showConfigConfirm, updateCon`
`500`	`500`	`x: calculatePos(shape, 'x', i, nodeWidthNum, nodeSpacerNum, columns, rows),`
`501`	`501`	`y: calculatePos(shape, 'y', i, nodeWidthNum, nodeSpacerNum, columns, rows),`
`502`	`502`	`color: config.visual.colors[theme],`
`503`		`- opacity: i + 1 > 100 - Math.round(Number(dataPercentage)) ? 1 : 0.2,`
`504`		`- isFilled: i + 1 > 100 - Math.round(Number(dataPercentage))`
	`503`	`+ opacity: isFilled ? 1 : 0.2,`
	`504`	`+ isFilled: isFilled`
`505`	`505`	`}`
`506`	`506`	`waffleData.push(newNode)`
`507`	`507`	`}`