adds facility active proportion field#341
Conversation
kingsleyiyawe
requested review from
PatrickTCorbett,
kgostic,
natemcintosh and
zsusswein
kingsleyiyawe
temporarily deployed
to
production
GitHub Actions
Inactive
kingsleyiyawe
temporarily deployed
to
production
GitHub Actions
Inactive
kingsleyiyawe
temporarily deployed
to
production
GitHub Actions
Inactive
kingsleyiyawe
temporarily deployed
to
production
GitHub Actions
Inactive
|
Thank you for your contribution @pre-commit-ci[bot] 🚀! Your pkgdown-site is ready for download 👉 here 👈! |
kgostic
left a comment
kgostic
left a comment
There was a problem hiding this comment.
I think we should change the default and I'd like @natemcintosh to review, but otherwise lgtm. Thank you!
|
(Approved so as not to hold you up but please address the comments before merging!) |
natemcintosh
left a comment
natemcintosh
left a comment
There was a problem hiding this comment.
It looks like these changes came from this section of the PR for backfill work? Just want to make sure I understand what's going on.
Looks good though.
|
Yes I made the code changes locally for the pipeline this morning using the backfill PR since I got errors for facility active proportion field being missing. |
kingsleyiyawe
temporarily deployed
to
production
GitHub Actions
Inactive
kingsleyiyawe
temporarily deployed
to
production
GitHub Actions
Inactive
* added facility active proportion field * updates NEWS.md * Update azure/generate_configs.py Co-authored-by: Katie Gostic <uep6@cdc.gov> * Update azure/generate_configs.py Co-authored-by: Katie Gostic <uep6@cdc.gov> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Katie Gostic <uep6@cdc.gov> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
3 participants
Good morning, this code change adds the facility active proportion field to the cfa-epinow2-pipeline repo after its addition to the cfa-config-generator repo last week.