Skip to content

344 create dynamic low case count thresholds#353

Merged
PatrickTCorbett merged 47 commits intomainfrom
344-create-dynamic-low-case-count-thresholds
Aug 26, 2025
Merged

344 create dynamic low case count thresholds#353
PatrickTCorbett merged 47 commits intomainfrom
344-create-dynamic-low-case-count-thresholds

Conversation

@PatrickTCorbett
Copy link
Copy Markdown
Collaborator

@PatrickTCorbett PatrickTCorbett commented Aug 15, 2025

Overview:
Create pathogen-specific low case count thresholds to use for labeling each state-pathogen pair as "n_low_case_counts" in the diagnostic file. "n_low_case_count" is assigned if the past week OR the week before that have less then X ED visits where X is the specified threshold. The state-pathogen pairs with a n_low_case_count flag will have their Rt values nulled and growth categories edited to "Not Estimated" in the post-processing repo.

Changes:

  1. Create find_low_count_threshold.R which reads in configs to determine threshold value
  2. Add threshold parameters to diagnostics.R functions
  3. Add low case count threshold as value in meatada.json file
  4. Edit all tests and tests files for diagnostic checks

Coinciding PR:
Coincides with PR in config generator CDCgov/cfa-config-generator#73 where the threshold are provided in the src/cfa_config_generator/utils/epinow2/constants.py file.

PatrickTCorbett and others added 8 commits August 13, 2025 17:06
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 15, 2025

Thank you for your contribution @PatrickTCorbett 🚀! Your pkgdown-site is ready for download 👉 here 👈!
(The artifact expires on 2025-09-02T18:20:53Z. You can re-generate it by re-running the workflow here.)

@PatrickTCorbett PatrickTCorbett marked this pull request as ready for review August 21, 2025 20:02
Copy link
Copy Markdown
Collaborator

@kgostic kgostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Comment thread R/config.R Outdated
Comment thread R/diagnostics.R Outdated
Co-authored-by: Katie Gostic <uep6@cdc.gov>
Copy link
Copy Markdown
Collaborator

@micahwiesner67 micahwiesner67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address the failing build due to outdated roxygen documentation by running roxygenize() locally and pushing

PatrickTCorbett added a commit to CDCgov/cfa-config-generator that referenced this pull request Aug 26, 2025
This update is meant to coincide with the PR in epinow2
CDCgov/cfa-epinow2-pipeline#353 to add in
pathogen-specific low case count thresholds.

This PR just adds disease-specific low case count thresholds that can be
read into the epinow2 pipeline.
Copy link
Copy Markdown
Collaborator

@natemcintosh natemcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed again. Looking good

@PatrickTCorbett PatrickTCorbett merged commit 46f3aeb into main Aug 26, 2025
12 checks passed
@PatrickTCorbett PatrickTCorbett deleted the 344-create-dynamic-low-case-count-thresholds branch August 26, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants