Skip to content

Commit 4ad7f7a

Browse files
fzhao99jakewheeler
andauthored
fix: minor design changes (#1410)
Co-authored-by: Jake Wheeler <jake.wheeler@skylight.digital>
1 parent efdd592 commit 4ad7f7a

6 files changed

Lines changed: 55 additions & 42 deletions

File tree

client/e2e/configurations.spec.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,11 @@ test.describe('Configurations screen', () => {
4444
'Death associated with disease caused by severe acute respiratory syndrome coronavirus 2 (event)'
4545
);
4646
await expect(page.getByRole('option', { name: 'COVID-19' })).toBeVisible();
47-
await page.getByRole('option', { name: 'COVID-19' }).click();
48-
49-
await expect(page.getByText('COVID-19')).toBeVisible();
47+
const covidOption = page.getByRole('option', { name: 'COVID-19' });
48+
await covidOption.click();
49+
await expect(covidOption).not.toBeVisible();
50+
await expect(page.getByText('Selected condition group')).toBeVisible();
51+
await expect(page.getByRole('table', { name: 'COVID-19' })).toBeVisible();
5052
await expect(page.getByText('1001411000124108')).toBeVisible();
5153
await expect(
5254
page.getByText(

client/package-lock.json

Lines changed: 24 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/src/components/Modal/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function Modal({
5757
open,
5858
onClose,
5959
children,
60-
position = 'center',
60+
position = 'top',
6161
maxWidth = 'lg',
6262
className,
6363
}: ModalProps) {
@@ -68,7 +68,7 @@ function Modal({
6868

6969
<div
7070
className={classNames(
71-
'fixed inset-0 z-50 flex justify-center overflow-auto p-4',
71+
'fixed inset-0 z-50 flex justify-center overflow-auto pt-15',
7272
{
7373
'items-center': position === 'center',
7474
'items-start': position === 'top',

0 commit comments

Comments
 (0)