move release note creation to rc job

Author: fzhao99

.github/workflows/build-release-candidate.yml

@@ -12,6 +12,10 @@ on:
       rc:
         description: "RC number (e.g. rc.1)"
         required: true
+      release_notes:
+        description: "Create release notes? Leave this unchecked if there are already notes created"
+        type: boolean
+        default: false
       dry_run:
         description: "If true, skip creating git tag and pushing Docker images"
         type: boolean
@@ -156,3 +160,13 @@ jobs:
           tags: ${{ steps.vars.outputs.ops_tags }}
           build-args: |
             VERSION=${{ steps.vars.outputs.version_tag }}
+
+      - name: Create draft GitHub release notes
+        if: ${{ github.event.inputs.dry_run == 'false' && github.event.inputs.release_notes == 'true' }}
+        uses: softprops/action-gh-release@v2
+        with:
+          tag_name: ${{ steps.vars.outputs.version_tag }}
+          name: Release ${{ steps.vars.outputs.version_tag }}
+          draft: true
+          prerelease: true
+          generate_release_notes: true

.github/workflows/promote-release-candidate.yml

@@ -172,13 +172,3 @@ jobs:
           GIT_TAG="${{ steps.vars.outputs.git_tag }}"
           git tag -a "$GIT_TAG" -m "Release $GIT_TAG (promoted from ${{ steps.vars.outputs.rc_version }})"
           git push origin "$GIT_TAG"
-
-      - name: Create draft GitHub release notes
-        if: ${{ github.event.inputs.dry_run == 'false' }}
-        uses: softprops/action-gh-release@v2
-        with:
-          tag_name: ${{ steps.vars.outputs.git_tag }}
-          name: Release ${{ steps.vars.outputs.git_tag }}
-          draft: true
-          prerelease: false
-          generate_release_notes: true

releases/RELEASE.md

@@ -19,12 +19,13 @@ This document will outline the process for releasing a new version of the eCR Re
    2. `version` = Semantic version to use (example: `1.4.0`)
    3. `rc` = the RC number (example: `rc.1`, note the `.` between `rc` and the number)
    4. `dry_run` = `false` (feel free to try using `true` first if you'd like to run a test without creating anything)
+   5. `release notes` = `true` (if this is a follow-up release candidate creation, leave this false)
 2. The job will push the new RC images to ECR and GHCR, which are ready to be deployed and tested. These images can be found at:
    - [refiner](https://github.com/CDCgov/dibbs-ecr-refiner/pkgs/container/dibbs-ecr-refiner%2Frefiner)
    - [lambda](https://github.com/CDCgov/dibbs-ecr-refiner/pkgs/container/dibbs-ecr-refiner%2Flambda)
    - [ops](https://github.com/CDCgov/dibbs-ecr-refiner/pkgs/container/dibbs-ecr-refiner%2Fops)
 
-3. Once the release candidate job runs, navigate to the [release page](https://github.com/CDCgov/dibbs-ecr-refiner/releases). Click the "Draft a new release" button and find the corresponding release tag for the images you just made.
+3. Once the release candidate job runs, navigate to the [release page](https://github.com/CDCgov/dibbs-ecr-refiner/releases). If this is the first time you've made a release for this family of releases, find the created release notes from the job. Optionally, you can also make the release notes manually by clicking "draft release notes"
    1. Title the release notes with "Release < RELEASE NUMBER >" without the `rc` suffix (ie Release 0.0.11) since the notes will only get published after the release is ready for publishing.
       ![Screenshot of default values](./release_details.png)
    1. Specify the previous tag using the dropdown and hit _generate release notes_.