Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Commit 36915d8

Browse files
tinogutierrezTino
tinogutierrez
and
Tino
authored
Yarn lint warnings frontend-react-original (#18917)
* fix: Refactor TableFilterSearch component and update test cases for DAPScript and Toast contexts * fix: move mock data and update tests to use new fixture structure * fix: tests with yarn lint testing-library/no-node-access * fix: playwright/max-nested-describe * fix: playwright/no-conditional-expect * fix: update tests to use 'fixme' for skipped scenarios in code mapping, sample payloads, daily data, and submission history pages * fix: update tests to use 'fixme' for skipped scenarios in last mile failures and receiver status pages --------- Co-authored-by: Tino <tino@Tinos-MacBook-Pro-2.local> Co-authored-by: Tino Gutierrez <tino.gutierrez@focusconsulting.io>
1 parent 81700db commit 36915d8

23 files changed

Lines changed: 264 additions & 408 deletions

‎frontend-react-original/e2e/spec/all/authenticated/admin/receiver-status-page.spec.ts‎

Lines changed: 62 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -145,47 +145,45 @@ test.describe("Admin Receiver Status Page", () => {
145145

146146
test.describe("Functions correctly", () => {
147147
test.describe("filters", () => {
148-
test.describe("date range", () => {
149-
test("works through calendar", async ({ adminReceiverStatusPage }) => {
150-
const { valueDisplay } = adminReceiverStatusPage.filterFormInputs.dateRange;
151-
const now = new Date();
152-
const targetFrom = startOfDay(subDays(now, 3));
153-
const targetTo = addDays(endOfDay(now), 1);
154-
155-
const reqUrl = await adminReceiverStatusPage.updateFilters({
156-
dateRange: {
157-
value: [targetFrom, targetTo],
158-
},
159-
});
160-
expect(reqUrl).toBeDefined();
161-
162-
await expect(valueDisplay).toHaveText(adminReceiverStatusPage.expectedDateRangeLabelText);
163-
expect(Object.fromEntries(reqUrl!.searchParams.entries())).toMatchObject({
164-
start_date: targetFrom.toISOString(),
165-
end_date: targetTo.toISOString(),
166-
});
148+
test("date range works through calendar", async ({ adminReceiverStatusPage }) => {
149+
const { valueDisplay } = adminReceiverStatusPage.filterFormInputs.dateRange;
150+
const now = new Date();
151+
const targetFrom = startOfDay(subDays(now, 3));
152+
const targetTo = addDays(endOfDay(now), 1);
153+
154+
const reqUrl = await adminReceiverStatusPage.updateFilters({
155+
dateRange: {
156+
value: [targetFrom, targetTo],
157+
},
167158
});
159+
expect(reqUrl).toBeDefined();
168160

169-
test("works through textboxes", async ({ adminReceiverStatusPage }) => {
170-
const { valueDisplay } = adminReceiverStatusPage.filterFormInputs.dateRange;
171-
await expect(adminReceiverStatusPage.receiverStatusRowsLocator).not.toHaveCount(0);
172-
const now = new Date();
173-
const targetFrom = startOfDay(subDays(now, 3));
174-
const targetTo = addDays(endOfDay(now), 1);
175-
176-
const reqUrl = await adminReceiverStatusPage.updateFilters({
177-
dateRange: {
178-
value: [targetFrom, targetTo],
179-
},
180-
});
181-
182-
expect(reqUrl).toBeDefined();
183-
184-
await expect(valueDisplay).toHaveText(adminReceiverStatusPage.expectedDateRangeLabelText);
185-
expect(Object.fromEntries(reqUrl!.searchParams.entries())).toMatchObject({
186-
start_date: targetFrom.toISOString(),
187-
end_date: targetTo.toISOString(),
188-
});
161+
await expect(valueDisplay).toHaveText(adminReceiverStatusPage.expectedDateRangeLabelText);
162+
expect(Object.fromEntries(reqUrl!.searchParams.entries())).toMatchObject({
163+
start_date: targetFrom.toISOString(),
164+
end_date: targetTo.toISOString(),
165+
});
166+
});
167+
168+
test("date range works through textboxes", async ({ adminReceiverStatusPage }) => {
169+
const { valueDisplay } = adminReceiverStatusPage.filterFormInputs.dateRange;
170+
await expect(adminReceiverStatusPage.receiverStatusRowsLocator).not.toHaveCount(0);
171+
const now = new Date();
172+
const targetFrom = startOfDay(subDays(now, 3));
173+
const targetTo = addDays(endOfDay(now), 1);
174+
175+
const reqUrl = await adminReceiverStatusPage.updateFilters({
176+
dateRange: {
177+
value: [targetFrom, targetTo],
178+
},
179+
});
180+
181+
expect(reqUrl).toBeDefined();
182+
183+
await expect(valueDisplay).toHaveText(adminReceiverStatusPage.expectedDateRangeLabelText);
184+
expect(Object.fromEntries(reqUrl!.searchParams.entries())).toMatchObject({
185+
start_date: targetFrom.toISOString(),
186+
end_date: targetTo.toISOString(),
189187
});
190188
});
191189

@@ -259,36 +257,34 @@ test.describe("Admin Receiver Status Page", () => {
259257
});
260258

261259
test.describe("receiver statuses", () => {
262-
test.describe("date range length changes", () => {
263-
test("increases", async ({ adminReceiverStatusPage }) => {
264-
const rows = adminReceiverStatusPage.receiverStatusRowsLocator;
265-
const days = rows.nthCustom(0).days;
266-
await expect(rows).not.toHaveCount(0);
267-
const now = new Date();
268-
const targetFrom = startOfDay(subDays(now, 3));
269-
const targetTo = endOfDay(now);
270-
await adminReceiverStatusPage.updateFilters({
271-
dateRange: {
272-
value: [targetFrom, targetTo],
273-
},
274-
});
275-
await expect(days).toHaveCount(4);
260+
test("date range length increases", async ({ adminReceiverStatusPage }) => {
261+
const rows = adminReceiverStatusPage.receiverStatusRowsLocator;
262+
const days = rows.nthCustom(0).days;
263+
await expect(rows).not.toHaveCount(0);
264+
const now = new Date();
265+
const targetFrom = startOfDay(subDays(now, 3));
266+
const targetTo = endOfDay(now);
267+
await adminReceiverStatusPage.updateFilters({
268+
dateRange: {
269+
value: [targetFrom, targetTo],
270+
},
276271
});
272+
await expect(days).toHaveCount(4);
273+
});
277274

278-
test("decreases", async ({ adminReceiverStatusPage }) => {
279-
const rows = adminReceiverStatusPage.receiverStatusRowsLocator;
280-
const days = rows.nthCustom(0).days;
281-
await expect(rows).not.toHaveCount(0);
282-
const now = new Date();
283-
const targetFrom = startOfDay(subDays(now, 1));
284-
const targetTo = endOfDay(now);
285-
await adminReceiverStatusPage.updateFilters({
286-
dateRange: {
287-
value: [targetFrom, targetTo],
288-
},
289-
});
290-
await expect(days).toHaveCount(2);
275+
test("date range length decreases", async ({ adminReceiverStatusPage }) => {
276+
const rows = adminReceiverStatusPage.receiverStatusRowsLocator;
277+
const days = rows.nthCustom(0).days;
278+
await expect(rows).not.toHaveCount(0);
279+
const now = new Date();
280+
const targetFrom = startOfDay(subDays(now, 1));
281+
const targetTo = endOfDay(now);
282+
await adminReceiverStatusPage.updateFilters({
283+
dateRange: {
284+
value: [targetFrom, targetTo],
285+
},
291286
});
287+
await expect(days).toHaveCount(2);
292288
});
293289

294290
test("time period modals", async ({ adminReceiverStatusPage }) => {

‎frontend-react-original/e2e/spec/all/authenticated/code-mapping-tool-page.spec.ts‎

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -140,26 +140,27 @@ test.describe("Code Mapping Tool Page", () => {
140140
await expect(codeMappingPage.page.getByText("Bad Request 400")).toBeVisible();
141141
});
142142

143-
test.skip("uploads a CSV file and 'Download table as CSV' button should download the file", async ({
144-
codeMappingPage,
145-
}) => {
146-
const downloadProm = codeMappingPage.page.waitForEvent("download");
143+
test.fixme(
144+
"uploads a CSV file and 'Download table as CSV' button should download the file",
145+
async ({ codeMappingPage }) => {
146+
const downloadProm = codeMappingPage.page.waitForEvent("download");
147147

148-
await codeMappingPage.page.goto("/onboarding/code-mapping");
149-
const fileInput = codeMappingPage.page.locator("input.usa-file-input__input");
150-
await fileInput.setInputFiles("e2e/fixtures/codemapping_success.csv", { noWaitAfter: true });
151-
await codeMappingPage.page.click('button:has-text("Submit")');
148+
await codeMappingPage.page.goto("/onboarding/code-mapping");
149+
const fileInput = codeMappingPage.page.locator("input.usa-file-input__input");
150+
await fileInput.setInputFiles("e2e/fixtures/codemapping_success.csv", { noWaitAfter: true });
151+
await codeMappingPage.page.click('button:has-text("Submit")');
152152

153-
const fileName = codeMappingPage.page.locator("h2 span > p:last-child");
154-
await expect(fileName).toHaveText("codemapping_success.csv");
153+
const fileName = codeMappingPage.page.locator("h2 span > p:last-child");
154+
await expect(fileName).toHaveText("codemapping_success.csv");
155155

156-
await codeMappingPage.page.click('button:has-text("Download table as CSV")');
156+
await codeMappingPage.page.click('button:has-text("Download table as CSV")');
157157

158-
const download = await downloadProm;
158+
const download = await downloadProm;
159159

160-
// assert filename
161-
expect(download.suggestedFilename()).toBe(fileName);
162-
});
160+
// assert filename
161+
expect(download.suggestedFilename()).toBe(fileName);
162+
},
163+
);
163164
});
164165

165166
/*
@@ -169,7 +170,7 @@ test.describe("Code Mapping Tool Page", () => {
169170
* */
170171
// This does not work as expected,
171172
// a receiver user should see an error on page
172-
test.skip("receiver user", () => {
173+
test.fixme("receiver user", () => {
173174
test.use({ storageState: "e2e/.auth/receiver.json" });
174175

175176
test("user", async ({ codeMappingPage }) => {

‎frontend-react-original/e2e/spec/all/public/about/about-page.spec.ts‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,8 @@ test.describe("About page", () => {
126126

127127
test.describe("Recommended Resources", () => {
128128
test("Card navigation", async ({ aboutPage }) => {
129+
// Cards with a url are navigable; cards without (e.g. PDF downloads) are click-only
129130
const cardLinks = [
130-
{
131-
name: "ReportStream overview PDF",
132-
url: "",
133-
},
134131
{
135132
name: "Product roadmap",
136133
url: "/about/roadmap",
@@ -143,11 +140,7 @@ test.describe("About page", () => {
143140

144141
for (const cardLink of cardLinks) {
145142
await aboutPage.page.getByTestId("CardGroup").getByRole("link", { name: cardLink.name }).click();
146-
147-
if (cardLink.url.length) {
148-
await expect(aboutPage.page).toHaveURL(cardLink.url);
149-
}
150-
143+
await expect(aboutPage.page).toHaveURL(cardLink.url);
151144
await aboutPage.page.goto(URL_ABOUT, {
152145
waitUntil: "domcontentloaded",
153146
});

‎frontend-react-original/e2e/spec/all/public/developer-resources/api/documentation/sample-payloads-and-output.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const test = baseTest.extend<SecurityPageFixtures>({
3636
});
3737

3838
// Page currently archived
39-
test.describe.skip(
39+
test.describe.fixme(
4040
"Developer Resources / API / Documentation / Sample payloads and output page",
4141
{
4242
tag: "@smoke",

0 commit comments

Comments
 (0)