Skip to content

Commit 63ffc8a

Browse files
committed
feat: add logging IAM policy, update logging bucket name, and extend ECS health check grace period
- Remove duplicate README file. - Introduce logging IAM policy document for S3 bucket operations. - Append "-logging" suffix to the logging bucket name. - Set ECS service health check grace period to 120 seconds.
1 parent 534b258 commit 63ffc8a

5 files changed

Lines changed: 26 additions & 120 deletions

File tree

README copy.md

Lines changed: 0 additions & 118 deletions
This file was deleted.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Table of Contents
2-
[1. Overview](#1-overview)\
2+
[1. Overview](#1-overview)
33
[2. Notices](#2-notices)
44
- [Table of Contents](#table-of-contents)
55
- [1. Overview](#1-overview)

_data.tf

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,28 @@ data "aws_iam_policy_document" "ecr_viewer_s3" {
2727
}
2828
}
2929

30+
data "aws_iam_policy_document" "logging" {
31+
statement {
32+
principals {
33+
type = "Service"
34+
identifiers = ["delivery.logs.amazonaws.com"]
35+
}
36+
actions = [
37+
"s3:PutObject",
38+
"s3:PutObjectAcl",
39+
"s3:GetObject",
40+
"s3:GetObjectAcl",
41+
"s3:ListBucket",
42+
"s3:GetBucketAcl",
43+
]
44+
resources = [
45+
aws_s3_bucket.logging.arn,
46+
"${aws_s3_bucket.logging.arn}/*",
47+
48+
]
49+
}
50+
}
51+
3052
data "aws_iam_policy" "ecs_task_execution" {
3153
name = "AmazonECSTaskExecutionRolePolicy"
3254
}

_local.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ locals {
266266
ecs_cloudwatch_group = var.ecs_cloudwatch_group == "" ? "/${local.local_name}" : var.ecs_cloudwatch_group
267267
ecs_cluster_name = var.ecs_cluster_name == "" ? local.local_name : var.ecs_cluster_name
268268
s3_viewer_bucket_name = var.s3_viewer_bucket_name == "" ? "${local.local_name}-${random_string.s3_viewer.result}" : var.s3_viewer_bucket_name
269-
s3_logging_bucket_name = var.s3_logging_bucket_name == "" ? "${local.local_name}-${random_string.s3_viewer.result}" : var.s3_logging_bucket_name
269+
s3_logging_bucket_name = var.s3_logging_bucket_name == "" ? "${local.local_name}-${random_string.s3_viewer.result}-logging" : var.s3_logging_bucket_name
270270
s3_viewer_bucket_role_name = var.s3_viewer_bucket_role_name == "" ? "${local.local_name}-ecrv" : var.s3_viewer_bucket_role_name
271271
tags = var.tags
272272
vpc_endpoints = [

ecs.tf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ resource "aws_ecs_service" "this" {
5757
deployment_minimum_healthy_percent = 50
5858
deployment_maximum_percent = 200
5959

60+
health_check_grace_period_seconds = 120
61+
6062
deployment_circuit_breaker {
6163
enable = true
6264
rollback = true

0 commit comments

Comments
 (0)