Skip to content

Commit 8693b5f

Browse files
authored
feat: update secrets manager input and add s3 delete permission (#33)
- Rename secrets_manager_postgresql_connection_string_version to secrets_manager_connection_string_version in documentation. - Add s3:DeleteObject action to the ecr_viewer_s3 data policy.
1 parent dec6a17 commit 8693b5f

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ No modules.
218218
| <a name="input_s3_viewer_bucket_role_name"></a> [s3\_viewer\_bucket\_role\_name](#input\_s3\_viewer\_bucket\_role\_name) | Name of the IAM role for the ecr-viewer bucket | `string` | `""` | no |
219219
| <a name="input_secrets_manager_auth_client_secret_version"></a> [secrets\_manager\_auth\_client\_secret\_version](#input\_secrets\_manager\_auth\_client\_secret\_version) | The secret containing the auth client secret. This is the secret that comes from the authentication provider. | `string` | `""` | no |
220220
| <a name="input_secrets_manager_auth_secret_version"></a> [secrets\_manager\_auth\_secret\_version](#input\_secrets\_manager\_auth\_secret\_version) | The secret containing the auth secret. This is used by eCR viewer to encrypt authentication. This can be generated by running `openssl rand -base64 32`. | `string` | `""` | no |
221-
| <a name="input_secrets_manager_postgresql_connection_string_version"></a> [secrets\_manager\_postgresql\_connection\_string\_version](#input\_secrets\_manager\_postgresql\_connection\_string\_version) | n/a | `string` | `""` | no |
221+
| <a name="input_secrets_manager_connection_string_version"></a> [secrets\_manager\_connection\_string\_version](#input\_secrets\_manager\_connection\_string\_version) | n/a | `string` | `""` | no |
222222
| <a name="input_secrets_manager_sqlserver_host_version"></a> [secrets\_manager\_sqlserver\_host\_version](#input\_secrets\_manager\_sqlserver\_host\_version) | n/a | `string` | `""` | no |
223223
| <a name="input_secrets_manager_sqlserver_password_version"></a> [secrets\_manager\_sqlserver\_password\_version](#input\_secrets\_manager\_sqlserver\_password\_version) | n/a | `string` | `""` | no |
224224
| <a name="input_secrets_manager_sqlserver_user_version"></a> [secrets\_manager\_sqlserver\_user\_version](#input\_secrets\_manager\_sqlserver\_user\_version) | n/a | `string` | `""` | no |

_data.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ data "aws_iam_policy_document" "ecr_viewer_s3" {
1717
actions = [
1818
"s3:PutObject",
1919
"s3:PutObjectAcl",
20+
"s3:DeleteObject",
2021
"s3:GetObject",
2122
"s3:GetObjectAcl",
2223
"s3:ListBucket",

0 commit comments

Comments
 (0)