refactor: remove time provider and add skip comments for ALB logging

- Remove unused hashicorp/time TerraForm provider dependency
- Add checkov and trivy skip comments for CKV_AWS_145 and AVD-AWS-0132 on
  ALB logging S3 bucket (expected - ALB logging is not compatible with
  customer managed KMS keys)

Related: alis/fix-logging-path

Author: alismx

_variable.tf

@@ -317,9 +317,9 @@ variable "disable_ecr" {
 }
 
 variable "enable_enhanced_ecr_registry_scanning" {
-  type = bool
+  type        = bool
   description = "Flag to enable enhanced ecr registry scanning, defaults to false"
-  default = false
+  default     = false
 }
 variable "tags" {
   type        = map(string)

alb.tf

@@ -25,7 +25,7 @@ resource "aws_alb" "ecs" {
     data.aws_iam_policy_document.s3_logging,
     aws_s3_bucket_server_side_encryption_configuration.logging,
   ]
-  tags       = local.tags
+  tags = local.tags
 }
 
 resource "aws_alb_target_group" "this" {

enable_ecr.tf

@@ -39,7 +39,7 @@ resource "aws_ecr_repository" "this" {
 }
 
 resource "aws_ecr_registry_scanning_configuration" "configuration" {
-  count        = var.disable_ecr == false && var.enable_enhanced_ecr_registry_scanning == true ? 1 : 0
+  count     = var.disable_ecr == false && var.enable_enhanced_ecr_registry_scanning == true ? 1 : 0
   scan_type = "ENHANCED"
 
   rule {

provider.tf

@@ -16,10 +16,6 @@ terraform {
       source  = "hashicorp/random"
       version = "~> 3.6.3"
     }
-    time = {
-      source  = "hashicorp/time"
-      version = "~> 0.13.1"
-    }
   }
   required_version = "~> 1.9.0"
 }

s3.tf

@@ -55,12 +55,14 @@ resource "aws_s3_bucket_public_access_block" "logging" {
   restrict_public_buckets = true
 }
 
+# checkov:skip=CKV_AWS_145:ALB logging is not fully compatible with customer managed keys
+# trivy:ignore:AVD-AWS-0132
 resource "aws_s3_bucket_server_side_encryption_configuration" "logging" {
   bucket = aws_s3_bucket.logging.bucket
   rule {
     # CANNOT USER CUSTOMER MANAGED KEYS WITH ALB LOGGING
     apply_server_side_encryption_by_default {
-      sse_algorithm     = "AES256"
+      sse_algorithm = "AES256"
     }
   }
 }