memcheck - clarify vector access #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
force-pushed
the
jeremy/memcheck-tidy
branch
from
cebe980 to
dbc5943
Compare
jeremylt
commented
Sep 16, 2024
jeremylt
force-pushed
the
jeremy/memcheck-tidy
branch
3 times, most recently
from
bdb8f9d to
7e5ca22
Compare
jeremylt
force-pushed
the
jeremy/memcheck-tidy
branch
from
7e5ca22 to
77d04a1
Compare
zatkins-dev
approved these changes
Sep 25, 2024
Collaborator
zatkins-dev
left a comment
zatkins-dev
left a comment
There was a problem hiding this comment.
Overall I think this clarifies memcheck behavior pretty well. I have some minor questions and a few suggestions, but otherwise this looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up the internals of the Memcheck CeedVector impl, making it clearer how we check access assumptions.
I then mirrored those changes into the QFunctionContext impl and threw in a bit of tidying for the QFunction too.