Skip to content

hip - fix minor leak #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

hip - fix minor leak #1742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions backends/hip-gen/ceed-hip-gen-operator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,15 @@ static int CeedOperatorApplyAdd_Hip_gen(CeedOperator op, CeedVector input_vec, C
if (eval_mode == CEED_EVAL_WEIGHT) { // Skip
data->fields.inputs[i] = NULL;
} else {
bool is_active;
CeedVector vec;

// Get input vector
CeedCallBackend(CeedOperatorFieldGetVector(op_input_fields[i], &vec));
if (vec == CEED_VECTOR_ACTIVE) vec = input_vec;
is_active = vec == CEED_VECTOR_ACTIVE;
if (is_active) vec = input_vec;
CeedCallBackend(CeedVectorGetArrayRead(vec, CEED_MEM_DEVICE, &data->fields.inputs[i]));
if (!is_active) CeedCallBackend(CeedVectorDestroy(&vec));
}
}

Expand All @@ -90,14 +93,17 @@ static int CeedOperatorApplyAdd_Hip_gen(CeedOperator op, CeedVector input_vec, C
if (eval_mode == CEED_EVAL_WEIGHT) { // Skip
data->fields.outputs[i] = NULL;
} else {
bool is_active;
CeedVector vec;

// Get output vector
CeedCallBackend(CeedOperatorFieldGetVector(op_output_fields[i], &vec));
if (vec == CEED_VECTOR_ACTIVE) vec = output_vec;
is_active = vec == CEED_VECTOR_ACTIVE;
if (is_active) vec = output_vec;
output_vecs[i] = vec;
// Check for multiple output modes
CeedInt index = -1;

for (CeedInt j = 0; j < i; j++) {
if (vec == output_vecs[j]) {
index = j;
Expand All @@ -109,6 +115,7 @@ static int CeedOperatorApplyAdd_Hip_gen(CeedOperator op, CeedVector input_vec, C
} else {
data->fields.outputs[i] = data->fields.outputs[index];
}
if (!is_active) CeedCallBackend(CeedVectorDestroy(&vec));
}
}

Expand Down Expand Up @@ -191,11 +198,14 @@ static int CeedOperatorApplyAdd_Hip_gen(CeedOperator op, CeedVector input_vec, C
CeedCallBackend(CeedQFunctionFieldGetEvalMode(qf_input_fields[i], &eval_mode));
if (eval_mode == CEED_EVAL_WEIGHT) { // Skip
} else {
bool is_active;
CeedVector vec;

CeedCallBackend(CeedOperatorFieldGetVector(op_input_fields[i], &vec));
if (vec == CEED_VECTOR_ACTIVE) vec = input_vec;
is_active = vec == CEED_VECTOR_ACTIVE;
if (is_active) vec = input_vec;
CeedCallBackend(CeedVectorRestoreArrayRead(vec, &data->fields.inputs[i]));
if (!is_active) CeedCallBackend(CeedVectorDestroy(&vec));
}
}

Expand All @@ -204,10 +214,12 @@ static int CeedOperatorApplyAdd_Hip_gen(CeedOperator op, CeedVector input_vec, C
CeedCallBackend(CeedQFunctionFieldGetEvalMode(qf_output_fields[i], &eval_mode));
if (eval_mode == CEED_EVAL_WEIGHT) { // Skip
} else {
bool is_active;
CeedVector vec;

CeedCallBackend(CeedOperatorFieldGetVector(op_output_fields[i], &vec));
if (vec == CEED_VECTOR_ACTIVE) vec = output_vec;
is_active = vec == CEED_VECTOR_ACTIVE;
if (is_active) vec = output_vec;
// Check for multiple output modes
CeedInt index = -1;

Expand All @@ -220,6 +232,7 @@ static int CeedOperatorApplyAdd_Hip_gen(CeedOperator op, CeedVector input_vec, C
if (index == -1) {
CeedCallBackend(CeedVectorRestoreArray(vec, &data->fields.outputs[i]));
}
if (!is_active) CeedCallBackend(CeedVectorDestroy(&vec));
}
}

Expand Down
Loading