-
Notifications
You must be signed in to change notification settings - Fork 62
Unified memory for HIP #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Unified memory for HIP #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b25906 to
a6008e9
Compare
Member
Author
|
I'm working through the implications, but I think we still need to let someone set a host pointer as a host pointer, so that's the only important change in this branch |
b314491 to
e54b387
Compare
Member
Author
|
With my changes $ make prove -j BACKENDS="/gpu/hip/ref /gpu/hip/shared /gpu/hip/gen"
...
t006-ceed ............... ok
t007-ceed ............... ok
t102-vector ............. ok
t110-vector ............. ok
t112-vector ............. ok
t113-vector ............. ok
t114-vector ............. ok
t115-vector ............. ok
t111-vector ............. ok
t116-vector ............. ok
t117-vector ............. ok
t118-vector ............. ok
t301-basis .............. ok
t303-basis .............. ok
t304-basis .............. ok
t305-basis .............. ok
t306-basis .............. ok
t508-operator ........... ok
t004-ceed ............... ok
t211-elemrestriction .... ok
t212-elemrestriction .... ok
t001-ceed ............... ok
t208-elemrestriction .... ok
t008-ceed ............... ok
t005-ceed ............... ok
t407-qfunction .......... ok
t413-qfunction .......... ok
t213-elemrestriction .... ok
t402-qfunction .......... ok
t211-elemrestriction-f .. ok
t002-ceed ............... ok
t009-ceed ............... ok
t202-elemrestriction .... ok
t408-qfunction .......... ok
t219-elemrestriction .... ok
t202-elemrestriction-f .. ok
t208-elemrestriction-f .. ok
t000-ceed-f ............. ok
t525-operator ........... ok
t404-qfunction .......... ok
t403-qfunction .......... ok
t120-vector ............. ok
t124-vector ............. ok
t003-ceed ............... ok
t212-elemrestriction-f .. ok
t000-ceed ............... ok
t203-elemrestriction .... ok
t124-vector-f ........... ok
t003-ceed-f ............. ok
t004-ceed-f ............. ok
t130-vector ............. ok
t001-ceed-f ............. ok
t215-elemrestriction .... ok
t103-vector ............. ok
t413-qfunction-f ........ ok
t402-qfunction-f ........ ok
t200-elemrestriction .... ok
t233-elemrestriction .... ok
t355-basis .............. ok
t107-vector ............. ok
t412-qfunction .......... ok
t231-elemrestriction .... ok
t362-basis .............. ok
t411-qfunction-f ........ ok
t310-basis .............. ok
t324-basis .............. ok
t210-elemrestriction .... ok
t220-elemrestriction .... ok
t109-vector ............. ok
t320-basis .............. ok
t342-basis .............. ok
t410-qfunction .......... ok
t104-vector ............. ok
t216-elemrestriction .... ok
t410-qfunction-f ........ ok
t412-qfunction-f ........ ok
t322-basis-f ............ ok
t504-operator-f ......... ok
t201-elemrestriction .... ok
t320-basis-f ............ ok
t306-basis-f ............ ok
t107-vector-f ........... ok
t101-vector-f ........... ok
t100-vector-f ........... ok
t323-basis-f ............ ok
t108-vector ............. ok
t510-operator-f ......... ok
t502-operator-f ......... ok
t503-operator-f ......... ok
t109-vector-f ........... ok
t401-qfunction-f ........ ok
t106-vector ............. ok
t123-vector ............. ok
t409-qfunction .......... ok
t102-vector-f ........... ok
t204-elemrestriction .... ok
t363-basis .............. ok
t122-vector ............. ok
t360-basis .............. ok
t101-vector ............. ok
t400-qfunction-f ........ ok
t207-elemrestriction .... ok
t523-operator-f ......... ok
t128-vector ............. ok
t406-qfunction .......... ok
t332-basis .............. ok
t125-vector ............. ok
t100-vector ............. ok
t300-basis .............. ok
t350-basis .............. ok
t411-qfunction .......... ok
t209-elemrestriction-f .. ok
t341-basis .............. ok
t322-basis .............. ok
t505-operator-f ......... ok
t400-qfunction .......... ok
t312-basis .............. ok
t331-basis .............. ok
t340-basis .............. ok
t522-operator-f ......... ok
t504-operator ........... ok
t317-basis .............. ok
t500-operator-f ......... ok
t321-basis .............. ok
t105-vector ............. ok
t511-operator-f ......... ok
t104-vector-f ........... ok
t530-operator-f ......... ok
t323-basis .............. ok
t311-basis .............. ok
t121-vector ............. ok
t405-qfunction .......... ok
t126-vector ............. ok
t127-vector ............. ok
t330-basis .............. ok
t401-qfunction .......... ok
t230-elemrestriction .... ok
t232-elemrestriction .... ok
t214-elemrestriction .... ok
t325-basis .............. ok
t209-elemrestriction .... ok
t205-elemrestriction .... ok
t217-elemrestriction .... ok
t307-basis .............. ok
t218-elemrestriction .... ok
t521-operator-f ......... ok
t234-elemrestriction .... ok
t302-basis .............. ok
t103-vector-f ........... ok
t533-operator-f ......... ok
t534-operator-f ......... ok
t108-vector-f ........... ok
t119-vector-f ........... ok
t535-operator-f ......... ok
t552-operator-f ......... ok
t210-elemrestriction-f .. ok
t106-vector-f ........... ok
t314-basis-f ............ ok
t201-elemrestriction-f .. ok
t119-vector ............. ok
t501-operator-f ......... ok
t300-basis-f ............ ok
t206-elemrestriction .... ok
t536-operator-f ......... ok
t540-operator-f ......... ok
t553-operator-f ......... ok
t105-vector-f ........... ok
t314-basis .............. ok
t550-operator-f ......... ok
t302-basis-f ............ ok
t200-elemrestriction-f .. ok
t532-operator-f ......... ok
t316-basis .............. ok
t509-operator ........... ok
t581-operator ........... ok
t315-basis .............. ok
t595-operator ........... ok
t414-qfunction .......... ok
t524-operator-f ......... ok
t520-operator-f ......... ok
t582-operator ........... ok
t590-operator ........... ok
t526-operator ........... ok
t353-basis .............. ok
t364-basis .............. ok
t523-operator ........... ok
t592-operator ........... ok
t570-operator ........... ok
t561-operator ........... ok
t580-operator ........... ok
t591-operator ........... ok
t560-operator ........... ok
t593-operator ........... ok
t594-operator ........... ok
t531-operator-f ......... ok
t568-operator ........... ok
t506-operator-f ......... ok
t567-operator ........... ok
t566-operator ........... ok
t562-operator ........... ok
t569-operator ........... ok
t511-operator ........... ok
t583-operator ........... ok
t530-operator ........... ok
t361-basis .............. ok
t534-operator ........... ok
t564-operator ........... ok
t510-operator ........... ok
t507-operator ........... ok
t550-operator ........... ok
t539-operator ........... ok
t563-operator ........... ok
t541-operator ........... ok
t537-operator ........... ok
t532-operator ........... ok
t500-operator ........... ok
t415-qfunction .......... ok
t505-operator ........... ok
t540-operator ........... ok
t565-operator ........... ok
t553-operator ........... ok
t535-operator ........... ok
t533-operator ........... ok
t501-operator ........... ok
t502-operator ........... ok
t531-operator ........... ok
t313-basis-f ............ ok
t503-operator ........... ok
t551-operator ........... ok
t552-operator ........... ok
t536-operator ........... ok
t506-operator ........... ok
ex3-volume .............. ok
t521-operator ........... ok
t538-operator ........... ok
t524-operator ........... ok
t520-operator ........... ok
t522-operator ........... ok
t356-basis .............. ok
t365-basis .............. ok
t357-basis .............. ok
t351-basis .............. ok
t313-basis .............. ok
t318-basis .............. ok
t352-basis .............. ok
t354-basis .............. ok
t554-operator ........... ok
t319-basis .............. ok
ex1-volume .............. ok
ex2-surface ............. ok
All tests successful.
Files=250, Tests=272, 127 wallclock secs ( 1.84 usr 0.63 sys + 9733.24 cusr 2277.66 csys = 12013.37 CPU)
Result: PASS |
e54b387 to
7064894
Compare
6681e46 to
40cd035
Compare
Co-authored-by: Zach Atkins <[email protected]>
40cd035 to
a3b195e
Compare
Open
Collaborator
|
All tests look good for me on Tuolumne. libCEED tests
Command: make -j prove PROVE_OPTS="-j4" BACKENDS="/gpu/hip/ref /gpu/hip/shared /gpu/hip/gen" NPROC_POOL=4Results: Ratel tests
Command make -j prove PROVE_OPTS="-j4" CEED_BACKENDS="/gpu/hip/ref /gpu/hip/shared /gpu/hip/gen" NPROC_POOL=4 |
zatkins-dev
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to test, but I think I got the important changes for the MI300A in here (note, made this branch on top of #1782)
This PR superceeds #1734