-
Notifications
You must be signed in to change notification settings - Fork 62
GPU Assembly AtPoints #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU Assembly AtPoints #1833
Conversation
58b80f9 to
55b5b14
Compare
|
Marked as ready for review - this passes the Ratel test suite cc @zatkins-dev because you were interested in the code generation - happy to step through the content with you in a screen share or otherwise |
b548db9 to
94d00b3
Compare
|
Note - we should also test somewhere with Ratel + this branch + HIP before merging |
|
Note to me - I forgot to generalize to multiple active bases. Small fix that's easy
|
|
Ok, that plan above actually won't work because of templates. I'm restricting this to just when we have a single active basis, which means we'll get best performance if we fieldsplit when we have multiple active bases, which is the plan anyways so we can use pMG on the displacement block. |
|
In that case, I think this is good! |
|
Do you have a machine you can check this branch with Ratel on quickly? |
2376943 to
8663e86
Compare
8663e86 to
217761a
Compare
This PR adds AtPoints assembly kernels to
*/genAnd then for the next PR I'll do