Clarify __syncthreads usage #1838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedbrown
reviewed
Jun 17, 2025
Member
jedbrown
left a comment
jedbrown
left a comment
There was a problem hiding this comment.
I know this is tedious to check for correctness. Would it be helpful to document on each function which arguments are shared memory and what the pre/post-conditions are regarding synchronization?
Member
Author
|
The rule of thumb is actually reasonably straightforward - any time we change the contents of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the intermittent t354 failures in CI
Basically, we really just need
__syncthreadswhen we're changing the contents shared memory buffers so I moved them to clarify this (and dropped a couple)