GPU Gen Full Assembly at Points #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
looks good at a glance - I'll do a full review tomorrow, but this is exciting! |
jeremylt
reviewed
Jun 18, 2025
jeremylt
reviewed
Jun 18, 2025
jeremylt
reviewed
Jun 18, 2025
zatkins-dev
force-pushed
the
zach/gen-full-assembly-at-points
branch
from
ba527de to
599548f
Compare
zatkins-dev
commented
Jun 18, 2025
zatkins-dev
force-pushed
the
zach/gen-full-assembly-at-points
branch
from
599548f to
692716b
Compare
Collaborator
Author
|
I don't understand how I failed codecov before but it's fine now |
…ator assembly over fallback
zatkins-dev
force-pushed
the
zach/gen-full-assembly-at-points
branch
from
19494ee to
a34b87f
Compare
jeremylt
approved these changes
Jun 18, 2025
Member
jeremylt
left a comment
jeremylt
left a comment
There was a problem hiding this comment.
Awesome, once Noether's happy we're good
Member
|
Oh, CodeCov is having some errors. So ignore that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds full single operator assembly at points for CUDA and HIP gen backends.