-
Notifications
You must be signed in to change notification settings - Fork 62
feat(sycl): Define CEED_RUNNING_JIT_PASS in JIT #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kris-rowe @uumesh Any foreseen issues with this? |
|
Not that I can think of. Does the kernel generation in the SYCL backend need to be updated to use include flags? |
|
Is this addition just for consistency? I don't think it will have any effect unless the JIT source is also modified. |
For consistency, and also to allow including character arrays in the header files (see MR here). The latter is more for coding convenience than anything else. Edit: We do have some HONEE jit sources that use libCEED/examples/fluids/qfunctions/advection.h Lines 11 to 14 in 6001dc9
|
It'd probably be nice in the future, but it's not blocking anything in HONEE. |
|
That should be fine. I also see that the flag adds a guard to exclude std/math libraries from the QFunctions. I am not sure if that will affect the compilation of OpenCL kernels. For example in the advection functions here |
|
It's been passing tests in HONEE, I'll double check with the libCEED tests real quick though. (HONEE should be a super set of the libCEED fluids tests). Edit: All the fluids tests pass with the exception of a few segfaults, but those were present before as well. |
|
This may be useful to add as well:
Lines 87-113 |
Update to include
CEED_RUNNING_JIT_PASSto the SYCL backend's definitions. This was added in #1696, but not to the SYCL backend.Confirmed this works on Aurora.