basis - fix flop counting for gpu at-points #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
force-pushed
the
jeremy/fix-flop-count
branch
from
04a4994 to
5278038
Compare
Member
Author
|
Ok, this should be a mild decrease in the number of flops |
Member
Author
|
new setup is noticeably faster on small laptop runs /gpu/cuda/shared old new |
zatkins-dev
reviewed
Jul 10, 2025
include/ceed/jit-source/hip/hip-shared-basis-tensor-at-points-templates.h
Outdated
Show resolved
Hide resolved
jeremylt
force-pushed
the
jeremy/fix-flop-count
branch
from
d998b37 to
56a8e69
Compare
zatkins-dev
reviewed
Jul 10, 2025
jeremylt
force-pushed
the
jeremy/fix-flop-count
branch
from
56a8e69 to
8aca9eb
Compare
zatkins-dev
reviewed
Jul 10, 2025
jeremylt
force-pushed
the
jeremy/fix-flop-count
branch
from
6ddf54c to
802d760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zatkins-dev does this change the plots significantly? We weren't counting all the GPU FLOPs for at-points basis evaluation quite correctly.