op - Add CeedOperatorApplyAddActive() for only summing into active outputs
#1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
reviewed
Jul 16, 2025
jeremylt
reviewed
Jul 16, 2025
jeremylt
reviewed
Jul 16, 2025
jeremylt
reviewed
Jul 16, 2025
zatkins-dev
force-pushed
the
zach/apply-add-active
branch
from
9d83fd9 to
5da5ab9
Compare
Member
|
We can drop some duplication by: Apply zeros active vectors and calls ApplyAddActive ApplyAddActive zeros passive vectors and calls ApplyAdd |
jeremylt
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gitlab.com/micromorph/ratel/-/merge_requests/1164 for more discussion.
Often, the passive outputs of a
CeedOperatorshould always be overwritten; e.g., auxiliary data from a residual evaluation used for Jacobian evaluation. Without this interface, one must useCeedOperatorApply()even if the desired behavior is to add into the active output vector, resulting in needing an extra scratch vector.