Skip to content

Conversation

@jeremylt
Copy link
Member

@jeremylt jeremylt commented Jul 24, 2025

We have CeedBasisCreateH1 and similar for almost all objects. I'm not sure why we treat CeedCompositeOperatorCreate differently?

@jeremylt jeremylt self-assigned this Jul 24, 2025
@jeremylt jeremylt force-pushed the jeremy/name-consistency branch 2 times, most recently from 161723c to 4c633d2 Compare July 24, 2025 19:51
@jeremylt
Copy link
Member Author

jeremylt commented Jul 24, 2025

Note - Julia hating this is expected as it is a beaking change to the API. We should only merge this branch right before release

Duh, forgot I could move some of the tests to dev only

@jedbrown
Copy link
Member

This seems like only a naming convention thing, and like it would be possible to preserve deprecated stubs for the old names. That would ease migration at what looks to be minimal cost.

@jeremylt
Copy link
Member Author

Yeah, preserving the stubs to the handful of old names would be easy.

@jeremylt jeremylt force-pushed the jeremy/name-consistency branch 2 times, most recently from df74f3e to ba68461 Compare July 24, 2025 21:59
@jeremylt jeremylt force-pushed the jeremy/name-consistency branch 4 times, most recently from 567ea5b to b039254 Compare July 28, 2025 15:48
@jeremylt jeremylt force-pushed the jeremy/name-consistency branch from b039254 to 52b0e56 Compare August 5, 2025 23:06
@jeremylt
Copy link
Member Author

jeremylt commented Aug 5, 2025

Any objections to merging this now? I think its ready

@jeremylt jeremylt mentioned this pull request Aug 5, 2025
@jeremylt jeremylt added this to the v1.0 milestone Aug 5, 2025
Copy link
Collaborator

@jrwrigh jrwrigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me.

@jeremylt jeremylt merged commit 1ad4660 into main Aug 6, 2025
29 checks passed
@jeremylt jeremylt deleted the jeremy/name-consistency branch August 6, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants