form: HTML sanitization and remove Source from CKEditor#2093
Merged
zzacharo merged 1 commit intoCERNDocumentServer:mainfrom Sep 1, 2025
Merged
form: HTML sanitization and remove Source from CKEditor#2093zzacharo merged 1 commit intoCERNDocumentServer:mainfrom
zzacharo merged 1 commit intoCERNDocumentServer:mainfrom
Conversation
zubeydecivelek
force-pushed
the
xss-injection
branch
3 times, most recently
from
79e7b8b to
506c849
Compare
4 tasks
zubeydecivelek
force-pushed
the
xss-injection
branch
from
506c849 to
a252cc6
Compare
zzacharo
previously approved these changes
Aug 26, 2025
ntarocco
previously approved these changes
Aug 27, 2025
Contributor
ntarocco
left a comment
ntarocco
left a comment
There was a problem hiding this comment.
The changes of the description fields look good.
Make sure that all other fields that receive free text input are correctly sanitizied.
Contributor
|
@zubeydecivelek from quickly checking, I found that we also render as HTML the translations description. Can you make sure it is sanitized? |
zubeydecivelek
dismissed stale reviews from ntarocco and zzacharo
via
fc55616
zubeydecivelek
force-pushed
the
xss-injection
branch
from
a252cc6 to
fc55616
Compare
zubeydecivelek
force-pushed
the
xss-injection
branch
from
fc55616 to
f5eebfd
Compare
zzacharo
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.