Skip to content

Switch to C++20 as a minimum requirement#1086

Merged
tpadioleau merged 4 commits intomainfrom
feature/c++-20
Mar 24, 2026
Merged

Switch to C++20 as a minimum requirement#1086
tpadioleau merged 4 commits intomainfrom
feature/c++-20

Conversation

@tpadioleau
Copy link
Copy Markdown
Member

@tpadioleau tpadioleau commented Mar 17, 2026

The PR bumps the minimum C++ standard from C++17 to C++20 (targeting CUDA 12.2 and ROCm 6.2 as the minimum supported backends). It includes three main changes:

  • Setting C++20 as the minimum requirement across the build system
  • Updating the CI and the oldest Docker image accordingly
  • Adding NVCC workarounds for compiler issues
  • Fixing modernize-use-constraints clang-tidy warnings by introducing proper C++20 concepts in the namespace ddc::concepts
  • Disabling modernize-use-integer-sign-comparison

@tpadioleau tpadioleau self-assigned this Mar 17, 2026
@tpadioleau tpadioleau force-pushed the feature/c++-20 branch 7 times, most recently from c9795a3 to 4133ac2 Compare March 17, 2026 15:14
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.89%. Comparing base (f5b37e7) to head (d57ae5c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   94.91%   94.89%   -0.02%     
==========================================
  Files          64       64              
  Lines        2849     2840       -9     
  Branches      892      892              
==========================================
- Hits         2704     2695       -9     
  Misses         95       95              
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpadioleau tpadioleau force-pushed the feature/c++-20 branch 2 times, most recently from 961ff44 to b2eef54 Compare March 18, 2026 17:27
@tpadioleau tpadioleau marked this pull request as ready for review March 18, 2026 17:47
@tpadioleau tpadioleau merged commit f86bfe7 into main Mar 24, 2026
79 of 101 checks passed
@tpadioleau tpadioleau deleted the feature/c++-20 branch March 24, 2026 06:34
@tpadioleau tpadioleau linked an issue Mar 24, 2026 that may be closed by this pull request
2 tasks
@tpadioleau tpadioleau mentioned this pull request Mar 24, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require C++20 as a minimum

1 participant