Function to print ChunkSpan for debugging purpose#819
Merged
tpadioleau merged 24 commits intoCExA-project:mainfrom Apr 24, 2025
Merged
Function to print ChunkSpan for debugging purpose#819tpadioleau merged 24 commits intoCExA-project:mainfrom
tpadioleau merged 24 commits intoCExA-project:mainfrom
Conversation
PaulGannay
commented
Apr 9, 2025
tpadioleau
requested changes
Apr 10, 2025
Member
tpadioleau
left a comment
tpadioleau
left a comment
There was a problem hiding this comment.
Looks good! Quick review relative to the coding style of DDC
PaulGannay
force-pushed
the
chunk_printing
branch
from
a29c18d to
989ec31
Compare
PaulGannay
commented
Apr 17, 2025
PaulGannay
force-pushed
the
chunk_printing
branch
from
2bdc4fd to
008ee02
Compare
tpadioleau
requested changes
Apr 18, 2025
PaulGannay
force-pushed
the
chunk_printing
branch
from
75707f0 to
9f29ef3
Compare
tpadioleau
reviewed
Apr 23, 2025
Member
|
Can you add your name to the AUTHORS file ? |
Correctly manage chunk that are not accessible from the host. Correctly manage 0d chunk. Correct tests
(it looks like msvc is doing a conversion to double before converting to hex)
tpadioleau
force-pushed
the
chunk_printing
branch
from
a4dc63b to
0b139b9
Compare
tpadioleau
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.