Prefer stride(i) instead of stride_i()#827
Merged
tpadioleau merged 1 commit intomainfrom Apr 16, 2025
Merged
Conversation
yasahi-hpc
approved these changes
Apr 16, 2025
Member
yasahi-hpc
left a comment
yasahi-hpc
left a comment
There was a problem hiding this comment.
LGTM.
Regarding internal Gbtrs, do you have a plan to suppress this in the future? All the serial solvers are available after KK 4.7.
Member
Author
I think last time we agreed on waiting the release that will have all these solvers. So if 4.7 has them all, that is fine to me. |
Member
|
Sounds good |
tpadioleau
deleted the
826-sanitize-extent-and-stride-usage-of-kokkosview
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a quick review, I think we don't have dangerous calls to
stride(i). We don't have functions that allow multiple ranks.