Use CMake file sets to install headers#915
Merged
tpadioleau merged 3 commits intomainfrom Sep 19, 2025
Merged
Conversation
4289180 to
541d2ae
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 55 55
Lines 2727 2727
Branches 853 853
=======================================
Hits 2564 2564
Misses 87 87
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
541d2ae to
598d827
Compare
598d827 to
6ff30f3
Compare
tretre91
reviewed
Sep 19, 2025
tretre91
approved these changes
Sep 19, 2025
Member
Author
|
thanks |
|
|
||
| #if !__has_include(<ddc/kernels/fft.hpp>) | ||
| # error | ||
| #else |
Member
There was a problem hiding this comment.
These are not critical. We can address them later if needed.
Earlier we just wanted to error out, now we want to include the file if it is available. The following order is simpler to read:
#if __has_include(<ddc/kernels/fft.hpp>)
# include <ddc/kernels/fft.hpp>
#else
# error
#endif
Also, an error message could be added.
Member
Author
There was a problem hiding this comment.
I agree I can rearrange them and add a small error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HEADERSFILE_SETto use DDC headers in the build and install tree.