Skip to content

Use CMake file sets to install headers#915

Merged
tpadioleau merged 3 commits intomainfrom
use-cmake-file-sets
Sep 19, 2025
Merged

Use CMake file sets to install headers#915
tpadioleau merged 3 commits intomainfrom
use-cmake-file-sets

Conversation

@tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Sep 14, 2025

  • Use CMake 3.25 support of HEADERS FILE_SET to use DDC headers in the build and install tree.
  • As a consequence this allows to have finer control of which headers are installed, whether fft, splines or the PDI wrapper are enabled.
  • Update the install test to detect missing headers.

@tpadioleau tpadioleau self-assigned this Sep 14, 2025
@codecov
Copy link

codecov bot commented Sep 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.02%. Comparing base (97e8db9) to head (587891e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files          55       55           
  Lines        2727     2727           
  Branches      853      853           
=======================================
  Hits         2564     2564           
  Misses         87       87           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpadioleau tpadioleau marked this pull request as ready for review September 17, 2025 12:23
@tpadioleau
Copy link
Member Author

thanks

@tpadioleau tpadioleau merged commit 97d7fd6 into main Sep 19, 2025
83 checks passed
@tpadioleau tpadioleau deleted the use-cmake-file-sets branch September 19, 2025 11:12

#if !__has_include(<ddc/kernels/fft.hpp>)
# error
#else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not critical. We can address them later if needed.

Earlier we just wanted to error out, now we want to include the file if it is available. The following order is simpler to read:

#if __has_include(<ddc/kernels/fft.hpp>)
#    include <ddc/kernels/fft.hpp>
#else
#    error
#endif

Also, an error message could be added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree I can rearrange them and add a small error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants