Update cmake minimum required to 3.25 and docker images#921
Conversation
bc43544 to
420be55
Compare
420be55 to
b351b70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 55 55
Lines 2727 2727
Branches 853 853
=======================================
Hits 2564 2564
Misses 87 87
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yasahi-hpc
left a comment
There was a problem hiding this comment.
LGTM
Can you also update the docs accordingly.
We set the documentation to reflect the status of the main branch ? |
In my opinion, it is more consistent. |
I agree it is more coherent with this part of the documentation. However I realize that we should not recommend a new user to use the main branch but the latest release version. |
That is probably better |
|
documentation updated in eb12f1e |
|
thanks |
add_subdirectory( SYSTEM))Note 1: Gyselalib++ is already requiring 3.25.
Note 2: we need to update the Spack package.