Skip to content

Update cmake minimum required to 3.25 and docker images#921

Merged
tpadioleau merged 2 commits intomainfrom
update-cmake-minimum-required
Sep 17, 2025
Merged

Update cmake minimum required to 3.25 and docker images#921
tpadioleau merged 2 commits intomainfrom
update-cmake-minimum-required

Conversation

@tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Sep 16, 2025

  • Update cmake minimum required to 3.25 (for cmake FILE_SET and add_subdirectory( SYSTEM))
  • Update docker images
  • Install PDI from Ubuntu packages

Note 1: Gyselalib++ is already requiring 3.25.
Note 2: we need to update the Spack package.

@tpadioleau tpadioleau self-assigned this Sep 16, 2025
@tpadioleau tpadioleau force-pushed the update-cmake-minimum-required branch 2 times, most recently from bc43544 to 420be55 Compare September 16, 2025 15:12
@tpadioleau tpadioleau force-pushed the update-cmake-minimum-required branch from 420be55 to b351b70 Compare September 16, 2025 15:13
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.02%. Comparing base (9301fc5) to head (eb12f1e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files          55       55           
  Lines        2727     2727           
  Branches      853      853           
=======================================
  Hits         2564     2564           
  Misses         87       87           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpadioleau tpadioleau marked this pull request as ready for review September 17, 2025 07:12
yasahi-hpc
yasahi-hpc previously approved these changes Sep 17, 2025
Copy link
Member

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you also update the docs accordingly.

@tpadioleau
Copy link
Member Author

LGTM

Can you also update the docs accordingly.

We set the documentation to reflect the status of the main branch ?

@yasahi-hpc
Copy link
Member

LGTM
Can you also update the docs accordingly.

We set the documentation to reflect the status of the main branch ?

In my opinion, it is more consistent.
If a new user try to follow the instruction, one will execute the following, which requires CMake 3.25

git clone --recurse-submodules --jobs 4 https://github.com/CExA-project/ddc.git
cmake -D DDC_BUILD_KERNELS_FFT=OFF \
      -D DDC_BUILD_KERNELS_SPLINES=OFF \
      -D DDC_BUILD_PDI_WRAPPER=OFF \
      -B ddc/build
cmake --build ddc/build --parallel 4
ctest --test-dir ddc/build
cmake --install ddc/build --prefix $HOME/.local/ddc

@tpadioleau
Copy link
Member Author

LGTM
Can you also update the docs accordingly.

We set the documentation to reflect the status of the main branch ?

In my opinion, it is more consistent. If a new user try to follow the instruction, one will execute the following, which requires CMake 3.25

git clone --recurse-submodules --jobs 4 https://github.com/CExA-project/ddc.git
cmake -D DDC_BUILD_KERNELS_FFT=OFF \
      -D DDC_BUILD_KERNELS_SPLINES=OFF \
      -D DDC_BUILD_PDI_WRAPPER=OFF \
      -B ddc/build
cmake --build ddc/build --parallel 4
ctest --test-dir ddc/build
cmake --install ddc/build --prefix $HOME/.local/ddc

I agree it is more coherent with this part of the documentation.

However I realize that we should not recommend a new user to use the main branch but the latest release version.

@yasahi-hpc
Copy link
Member

LGTM
Can you also update the docs accordingly.

We set the documentation to reflect the status of the main branch ?

In my opinion, it is more consistent. If a new user try to follow the instruction, one will execute the following, which requires CMake 3.25

git clone --recurse-submodules --jobs 4 https://github.com/CExA-project/ddc.git
cmake -D DDC_BUILD_KERNELS_FFT=OFF \
      -D DDC_BUILD_KERNELS_SPLINES=OFF \
      -D DDC_BUILD_PDI_WRAPPER=OFF \
      -B ddc/build
cmake --build ddc/build --parallel 4
ctest --test-dir ddc/build
cmake --install ddc/build --prefix $HOME/.local/ddc

I agree it is more coherent with this part of the documentation.

However I realize that we should not recommend a new user to use the main branch but the latest release version.

That is probably better

@tpadioleau
Copy link
Member Author

documentation updated in eb12f1e

@tpadioleau
Copy link
Member Author

thanks

@tpadioleau tpadioleau merged commit 97e8db9 into main Sep 17, 2025
34 checks passed
@tpadioleau tpadioleau deleted the update-cmake-minimum-required branch September 17, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants