Bugfix in compare_to_kgo #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hi @dustinswales , please could you review this change? Thanks! |
dustinswales
approved these changes
Feb 25, 2025
Contributor
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@alejandrobodas These changes look good to me. Thanks for adding them!
brandonduran
pushed a commit
to brandonduran/COSPv2.0
that referenced
this pull request
Feb 25, 2025
* Update continuous_integration.yml * Update cosp_config.F90 * Update continuous_integration.yml * Update continuous_integration.yml * Update containerized-ci.yml * Update to KGOs v005 for containerized-ci. * v005 KGO for containerized-ci. * md5 sums for v005 ifort and ifx KGOs. * gfortran KGOs v004. * Undo version upgrade of KGOs in CI tests. * Undo changes in CI workflows. * Add extra bin to force error. * Trap failure in summary_stats. * Trap error in difference and y tick labels. * Always test against KGOs. * Always test against KGOs. * Undo extra ice cloud bin. * Retain original formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is failure in the comparison of the outputs against the KGO and the generation of the plots also fails (e.g. due to a change in the dimensions of one of the outputs like in #110 ), then the tgz files with the new outputs are not created. This fixes this by trapping the error in compare_to_kgo.py. The CI workflows are slightly modified: all the comparisons against the KGOs are run even after failure in previous comparisons. I'm also adding the md5 sums of the KGOs for #110