Skip to content

Arrangement_2: Add types and functions to become a FaceGraph#1694

Closed
afabri wants to merge 5 commits intoCGAL:masterfrom
afabri:Arrangement_2-graph_traits-GF
Closed

Arrangement_2: Add types and functions to become a FaceGraph#1694
afabri wants to merge 5 commits intoCGAL:masterfrom
afabri:Arrangement_2-graph_traits-GF

Conversation

@afabri
Copy link
Copy Markdown
Member

@afabri afabri commented Nov 15, 2016

Partial fix for Issue #1004

The conversion between edges and halfeges is lacking.

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Nov 17, 2016

Is this PR finished? What does it add actually?

@afabri
Copy link
Copy Markdown
Member Author

afabri commented Nov 18, 2016

It is not finished and I better had marked it as WIP.
The goal is to make Arrangements model of FaceGraph, but honestly I do not even know which algorithm one might run on an arrangement. Also I am not sure what to do with holes, edges with the same face on both sides, isolated points....

@lrineau lrineau added TODO Not yet approved The feature or pull-request has not yet been approved. labels Nov 18, 2016
@efifogel
Copy link
Copy Markdown
Member

The following make sense and is useful:

| Graph Vertices | Graph Edges | Name

1 | Arr Vertices | Arr Edges | primary
2 | Arr Faces | Arr Edges | Dual
3 | Arr vertices, Edges, & Faces | Incidence relations | Complete


/_____/) o /_________ __ //
(____ ( ( ( (/ (/-(-'_(/
_/

On Fri, Nov 18, 2016 at 11:31 AM, Andreas Fabri notifications@github.com
wrote:

It is not finished and I better had marked it as WIP.
The goal is to make Arrangements model of FaceGraph, but honestly I do not
even know which algorithm one might run on an arrangement. Also I am not
sure what to do with holes, edges with the same face on both sides,
isolated points....


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1694 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGoWuA2V2u9qUJDK1nZ-rsIBUm1l_rf6ks5q_XBbgaJpZM4KyvcH
.

@lrineau lrineau added this to the 4-11-beta milestone Jan 3, 2017
@lrineau
Copy link
Copy Markdown
Member

lrineau commented May 30, 2017

@afabri @efifogel What is the status of this PR? It was left unmodified for a long time.

@efifogel
Copy link
Copy Markdown
Member

efifogel commented Jun 3, 2017 via email

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jun 6, 2017

Then @afabri, can you comment?

@lrineau lrineau added the Stalled label Jun 6, 2017
@lrineau lrineau modified the milestones: 4.11-beta, 4.12-beta Jun 27, 2017
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Aug 9, 2017

@afabri, I suggest we close this PR.

@lrineau lrineau modified the milestones: 4.12-beta, 4.13-beta Jan 24, 2018
@lrineau lrineau removed this from the 4.13-beta milestone Jun 26, 2018
@lrineau lrineau added this to the Trash / Attic milestone Jan 7, 2019
@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jun 20, 2019

More than two years old... I close the pull-request.

@lrineau lrineau closed this Jun 20, 2019
@MaelRL MaelRL removed the Stalled label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not yet approved The feature or pull-request has not yet been approved. TODO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants