Further upstream fixes #1797
Conversation
Some STL implementations may call comparator(x, x) to verify irreflexivity. Fix to not violate less preconditions in such an environment.
| template < class Traits_ > | ||
| struct Arr_complete_left_side_category { | ||
| public: | ||
| npublic: |
There was a problem hiding this comment.
I'm pretty sure this is not compiling.
There was a problem hiding this comment.
+1 That cannot compile! Please Michael, you have to fix that file.
| { | ||
| T | ||
| missing__Left_side_category__assuming__Arr_oblivious_side_tag__instead; | ||
| missing__Left_side_category__assuming__Arr_oblivious_side_tag__instead __attribute__((unused)); |
There was a problem hiding this comment.
I don't think __attribute__ is defined on MSCV?
There was a problem hiding this comment.
In <CGAL/config.h>, we have a macro CGAL_UNUSED that can be used. Its value is __attribute__ ((__unused__)) for gcc and clang, and empty for other compilers.
| /* Suppress unused-variable warnings when assertions are disabled. */ | ||
| (void)v_num; | ||
| (void)e_num; | ||
| (void)f_num; |
There was a problem hiding this comment.
you can use CGAL_USE macro instead.
| template < class Traits_ > | ||
| struct Arr_complete_left_side_category { | ||
| public: | ||
| npublic: |
There was a problem hiding this comment.
+1 That cannot compile! Please Michael, you have to fix that file.
|
This PR is waiting for modifications from you. We have entered the code freeze today. If you do not react sufficiently early, this PR will not make it into CGAL-4.10-beta1. |
|
@mhsaar I wrote a message in this discussion four weeks ago, and it remained unanswered. Can you please acknowledge that you receive those notifications? |
lrineau
changed the base branch from
releases/CGAL-4.13-branch
to
releases/CGAL-4.12-branch
4 participants
No description provided.