Polyhedron demo: New API for new features#2501
Closed
maxGimeno wants to merge 47 commits intoCGAL:masterfrom
Closed
Polyhedron demo: New API for new features#2501maxGimeno wants to merge 47 commits intoCGAL:masterfrom
maxGimeno wants to merge 47 commits intoCGAL:masterfrom
Conversation
Contributor
Author
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
from
bcd88ac to
974531f
Compare
Member
|
Note that this branch already conflicts with master. |
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
from
974531f to
002487a
Compare
lrineau
reviewed
Oct 6, 2017
| faces_displayed = true; | ||
| all_primitives_displayed = false; | ||
| has_vcolors = false; | ||
| has_fcolors = false; |
Member
There was a problem hiding this comment.
The body of the two constructors are identical. It should be factorized into a helper method of the class.
Contributor
Author
|
Doc updated |
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
from
f073866 to
3f1135a
Compare
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
from
46d4301 to
9109527
Compare
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
from
9109527 to
d920250
Compare
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
4 times, most recently
from
3f5b7a7 to
41e3cd1
Compare
lrineau
reviewed
Nov 30, 2017
| d->was_selected = true; | ||
| redraw(); | ||
| QTimer::singleShot(500, [this]{setSelected(false); redraw();}); | ||
| QTimer::singleShot(500, this, SLOT(unSelect())); |
Member
There was a problem hiding this comment.
Alternatively, you could have used:
QTimer::singleShot(500, this, [this]{setSelected(false); redraw();});with three arguments.
See the doc: http://doc.qt.io/qt-5/qtimer.html#singleShot-2
Contributor
Author
|
Oh, thanks for the indication, that will be far better
2017-11-30 18:19 GMT+01:00 Laurent Rineau <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In Polyhedron/demo/Polyhedron/Scene_item.cpp
<#2501 (comment)>:
> @@ -181,7 +181,7 @@ void CGAL::Three::Scene_item::selection_changed(bool b)
setSelected(true);
d->was_selected = true;
redraw();
- QTimer::singleShot(500, [this]{setSelected(false); redraw();});
+ QTimer::singleShot(500, this, SLOT(unSelect()));
Alternatively, you could have used:
QTimer::singleShot(500, this, [this]{setSelected(false); redraw();});
with three arguments.
See the doc: http://doc.qt.io/qt-5/qtimer.html#singleShot-2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2501 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKyW1ZYJJx9_E6bNjQw3sqzAnbxzhIw6ks5s7uOJgaJpZM4Pu0DC>
.
|
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
from
71e047f to
53a11d8
Compare
… have to be recalculated everytime their visibility is changed
- Buffer_objects - Edge_container - Io_plugins - Primitive_container - Scene_group_item - Scene_interface - Scene_item - Triangle_container - Viewer Interface
… helper class for convenient rendering function
… surface_mesh for non-convex quads.
…he mainwindow and the scene.
maxGimeno
force-pushed
the
New_generation_demo-GF
branch
from
f12819d to
6fe4150
Compare
Member
|
This change is |
Member
|
That reading might be interesting. |
16 tasks
…for SIGNAL/SLOTS connections with the scene.
Member
|
We're closing this PR as we won't have time to finish it. Transparency and multiple viewers were added in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR holds an API breaking update of the Polyhedron demo. This allows to add new features, like: