Replace \internal by \cond + always use SKIP_IN_MANUAL as string#2609
Closed
sloriot wants to merge 3 commits intoCGAL:masterfrom
Closed
Replace \internal by \cond + always use SKIP_IN_MANUAL as string#2609sloriot wants to merge 3 commits intoCGAL:masterfrom
sloriot wants to merge 3 commits intoCGAL:masterfrom
Conversation
lrineau
added
the
Not yet approved
Member
|
I disagree with this PR. |
Member
Author
|
Then I did not understand what you wanted to do to fix the issue. Could you be more precise about what you expected? |
Member
|
First, a discussion, then a decision, and then the patch. I will go on with the discussion in |
Member
Member
Author
|
That's your issue, I did not understand it correctly so up to you. |
MaelRL
added
Doc
Enhancement
Cleaning
and removed
Not yet approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2448
TODO: