Closed
Conversation
sloriot
added
the
Not yet approved
mglisse
reviewed
Mar 11, 2018
| #ifdef CGAL_USE_CORE | ||
|
|
||
| #ifdef CGAL_USE_GMPXX | ||
| inline CORE::BigFloat to_BigFloat( mpq_class const& n ) |
Member
There was a problem hiding this comment.
Shouldn't we add stuff to CORE_coercion_traits.h instead?
Member
|
@sloriot Do you still want that change in CGAL-4.12-beta2 or CGAL-4.12? |
Member
|
@sloriot Could you check the status of this PR? |
Member
Author
|
Stalled |
- parallel bisectors - factor used for rationalisation is 0
MaelRL
added
Work in progress
and removed
Tests failing
known false-positive in CI checks
Stalled
labels
MaelRL
added
Replaced
and removed
Not yet approved
Member
|
Replaced by #4905. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some predicates used in the straight skeleton require several square roots. This robustifies one predicate and increases the precision of 2 constructions used in predicates.