GSoC 2018: 2D Boolean set Operations demo#3306
GSoC 2018: 2D Boolean set Operations demo#3306apurvakbh wants to merge 13 commits intoCGAL:masterfrom
Conversation
|
I have many warnings when using |
efifogel
left a comment
efifogel
left a comment
There was a problem hiding this comment.
This program demonstrates the 2D regularized Boolean operations. It's the 1st release of such a demo program based on Qt5. Currently (excluding this demo) the 2D regularized operations are not demonstrated by any demo program, so it's a good intensive to release it. It lacks several features, but it's in a satisfactory shape. I do recommend the release.
|
This branch weights 2724kB. @sloriot, would you mind have a look if that is normal, or can be fixed? |
|
There are a lot of warnings or compilation errors, in the testsuite: |
|
Should be ok now.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 10 Oct 2018 at 11:36, Laurent Rineau ***@***.***> wrote:
There are a lot of warnings or compilation errors, in the testsuite:
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.14-Ic-14/Boolean_set_operations_2_Demo/TestReport_gimeno_CentOS6.gz
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGoWuFq0QG35VtVXA1aL_B398VfXqKtgks5ujbGAgaJpZM4WWECO>
.
|
|
I do not see any push. What have you modified? |
|
cgal-public-dev/gsoc2018-bso_demo-apurva
commit cc91f57
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 10 Oct 2018 at 17:07, Laurent Rineau ***@***.***> wrote:
I do not see any push. What have you modified?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGoWuJxEaDX2G6AqVxyDpTPJo6b68R1fks5ujf89gaJpZM4WWECO>
.
|
|
The push should be done in the |
|
ok, I'll ask Apurva for write permissions and fix it myself in the right
branch.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Wed, 10 Oct 2018 at 17:32, Laurent Rineau ***@***.***> wrote:
The push should be done in the master branch of the repo ***@***.***:
apurva786/cgal.git, that is the branch of this PR. If you do not have the
rights for that, then either @apurva786 <https://github.com/apurva786>
will have to do it, or we will replace this PR by another one you create.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGoWuHiDVQjQKZgpIdZnn763-oZrmMkHks5ujgUKgaJpZM4WWECO>
.
|
The branch's size is big because it contains some images(in the resources folder). All of them are not used currently, but I have kept them in case they might be useful for future developers. |
|
@apurva786 commented on Oct 11, 2018, 6:28 AM GMT+2:
That is true. And it is also big because you committed, then removed, binary files:
|
|
ok, I've updated the remote branch.
The demo should compile now without warnings.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Thu, 11 Oct 2018 at 12:27, Laurent Rineau ***@***.***> wrote:
***@***.**** <https://github.com/apurva786> commented on Oct 11, 2018,
6:28 AM GMT+2
<#3306 (comment)>:
The branch's size is big because it contains some images(in the resources
folder). All of them are not used currently, but I have kept them in case
they might be useful for future developers.
That is true. And it is also big because you committed, then removed,
binary files:
- 6088a04
<6088a04>
- 2D Boolean operations demo (6 weeks ago)
.../Boolean_set_operations_2 | Bin 39101624 -> 0 bytes
.../Boolean_set_operations_2.tar.gz | Bin 6316570 -> 0 bytes
- 965b800
<965b800>
- 2D Boolean operations demo (6 weeks ago)
.../Boolean_set_operations_2 | Bin 0 -> 39101624 bytes
.../Boolean_set_operations_2.tar.gz | Bin 0 -> 6316570 bytes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGoWuIdMoM312RTfiHYMBJlpxYh47DTpks5ujw7rgaJpZM4WWECO>
.
|
|
There are still many warnings. |
|
@apurva786 could you please add me and @maxGimeno as collaborators? |
|
Is this the expected windows? I don't see any of my input polygon in the list. Also if I draw an invalid polygon, the demo simply crashes. We should add a test that consider a polygon only if it is valid and otherwise display an error message (a bad click can happen to anyone and we don't want the whole session to be gone for a bad click). |
|
I have added @maxGimeno as a collaborator. @maxGimeno can you please elaborate the statement "I don't see any of my input polygon in the list." I would like to mention the console, Infos and the buttons under Geometric objects are disabled, but the radio buttons and checkbox are working. The demo is expected to work like as shown in this video link Regarding how to use the demo |
|
Thanks @apurva786 , I was able to push. |
|
@sloriot The plus('+') sign is meant to be used to load a polygon in the demo from the stored polygons using file reading. It can be removed, and add the same function in the File drop down. The minus('-') sign is not needed at all. It can be removed. The third sign(which looks like a file) it can be used to duplicate the currently selected polygon. The up and down keys are not useful now, but I have kept them in case it might be useful when the demo is enhanced to 3-D. The same goes for the tab with "Quick filter" written in it. Might be useful for 3-D. We can remove those UI components for now. It won't take much time for the future developers to add them again. |
|
Hi Apurva,
First, thanks for the dedication. It is appreciated!
Regarding self intersections, any one of the Boolean operation accepts only
valid operations.
The definition of "valid" appears in the documentation. It goes beyond self
intersections.
There is a function that tests whether a polygon is a valid operand of a
Boolean operation.
All we need to do is add a call to this function and react.
There is a similar function for a polygon with holes; see
Gps_polygon_validation::is_valid_unknown_polygon(polygon, traits)
Gps_polygon_validation::is_valid_unknown_polygon(polygon-with-holes, traits)
Efi
…____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
On Tue, 6 Nov 2018 at 09:26, Apurva Bhatt ***@***.***> wrote:
@sloriot <https://github.com/sloriot> The plus('+') sign is meant to be
used to load a polygon in the demo from the stored polygons using file
reading. It can be removed, and add the same function in the File drop down.
The minus('-') sign is not needed at all. It can be removed.
The third sign(which looks like a file) it can be used to duplicate the
currently selected polygon.
The up and down keys are not useful now, but I have kept them in case it
might be useful when the demo is enhanced to 3-D.
The same goes for the tab with "Quick filter" written in it. Might be
useful for 3-D.
We can remove those UI components for now. It won't take much time for the
future developers to add them again.
A question. Can we make a valid 2D polygon which intersects with
itself(one segment intersects with another segment of the same polygon)?
The polygon is made using
CGAL::Arr_segment_traits_2CGAL::Exact_predicates_exact_constructions_kernel
I am not able to make one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGoWuBMc_0dERiZp8KLLF0Mn3GASJmCzks5usTm5gaJpZM4WWECO>
.
|
|
Thank you @efifogel I will try to use these functions. |
|
Hello, what is the status of this branch ? @sloriot it is written that you have some filtering to do, but also there is something to be done about degenerated polygons. |
|
@efifogel @apurva786 No change to the PR since November 2018. This PR will probably not make it into CGAL-4.14. |
lrineau
added
rm: not for next release
lrineau
removed
the
rm: not for next release
|
Still no change, I move it to Attic/Trash |
|
@efifogel what is the status of this pull request? |
|
Let's toss it.
Since then the code has been improved by succeeding GSOC projects.
The latest one (I think) is in gsoc2021-bso_demo-kedia.
I'll look at it soon.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Mon, 3 Jan 2022 at 14:44, Sebastien Loriot ***@***.***> wrote:
@efifogel <https://github.com/efifogel> what is the status of this pull
request?
—
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOECM6TAAOZ22QFKRBDUUGK3DANCNFSM4FSYICHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@efifogel If I got it right, we can close this PR? |
|
Naturally, I still would like to complete the demo and publish it.
It requires some more work, so if you think it's the right thing to do,
close it, and when the necessary improvements are done, I'll create a new
pull request.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Mon, 18 Dec 2023 at 15:04, Sebastien Loriot ***@***.***> wrote:
@efifogel <https://github.com/efifogel> If I got it right, we can close
this PR?
—
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOGJLQERQSFU3IGKFP3YKA5N7AVCNFSM4FSYICHKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGA2DINRYHE4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I don't want to close it but my understanding is that this work is obsolete and another branch does exist (but maybe I misunderstood) |
|
Aha; you are correct.
The branch that contains the most up-to-date version, and the only one that
matters, is gsoc2021-bso_demo-kedia.
So any pull-request of older versions is obsolete.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Tue, 19 Dec 2023 at 14:59, Sebastien Loriot ***@***.***> wrote:
I don't want to close it but my understanding is that this work is
obsolete and another branch does exist (but maybe I misunderstood)
—
Reply to this email directly, view it on GitHub
<#3306 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNODACDHRC5UD5UCBAETYKGFS3AVCNFSM4FSYICHKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGI3TCNBVHEZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
6 participants
Please add this branch to the master branch.
The brach contains 2D Boolean set Operations demo. It was done as a part of the gsoc 2018 project. It was done under mentor-ship of Efi Fogel and Andreas Fabri.
TODO: