Skip to content

WIP: Add timer to see which example is time consuming (temporary PR)#3397

Closed
afabri wants to merge 6 commits intoCGAL:masterfrom
afabri:Mesh_3-Timer-GF
Closed

WIP: Add timer to see which example is time consuming (temporary PR)#3397
afabri wants to merge 6 commits intoCGAL:masterfrom
afabri:Mesh_3-Timer-GF

Conversation

@afabri
Copy link
Copy Markdown
Member

@afabri afabri commented Oct 12, 2018

Summary of Changes

Add timer in the Mesh_3 examples to see what takes time in the VC2013 testsuite.
Not really targeted for integration into master.

@lrineau lrineau added Ready to be tested Not yet approved The feature or pull-request has not yet been approved. labels Oct 12, 2018
@lrineau lrineau self-assigned this Oct 12, 2018
@lrineau
Copy link
Copy Markdown
Member

lrineau commented Oct 12, 2018

https://travis-ci.org/CGAL/cgal/jobs/440522930#L3477

[ 52%] Building CXX object CMakeFiles/mesh_hybrid_mesh_domain.dir/mesh_hybrid_mesh_domain.cpp.o
/home/travis/build/CGAL/cgal/Mesh_3/examples/Mesh_3/mesh_two_implicit_spheres_with_balls.cpp:105:14: error: 
      expected ';' after expression
  CGAL::Timer timer; timer.start();
             ^
             ;
/home/travis/build/CGAL/cgal/Mesh_3/examples/Mesh_3/mesh_two_implicit_spheres_with_balls.cpp:105:3: error: 
      no member named 'Timer' in namespace 'CGAL'; did you mean 'timer'?
  CGAL::Timer timer; timer.start();
  ^~~~~~~~~~~
  timer

Please test what you push!

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Oct 12, 2018

I fixed the compilation errors. And I tested! 2 minutes of my time, and 10 minutes of my computer time...

sloriot and others added 2 commits October 29, 2018 15:21
Something got wrong in the previous git-rebase.
@lrineau
Copy link
Copy Markdown
Member

lrineau commented Dec 3, 2018

This PR was tested in https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.14-Ic-30/Mesh_3/TestReport_afabri_x64_Cygwin-Windows10_MSVC2013-Debug-64bits.gz

Consuming tests:

------------------------------------------------------------------
- ProgramOutput.test_mesh_3_issue_1554.x64_Cygwin-Windows10_MSVC2013-Debug-64bits
------------------------------------------------------------------
[...]
1106.77sec
------------------------------------------------------------------
- ProgramOutput.test_meshing_3D_gray_image.x64_Cygwin-Windows10_MSVC2013-Debug-64bits
------------------------------------------------------------------
[...]
3272.29sec
------------------------------------------------------------------
- ProgramOutput.test_meshing_3D_image.x64_Cygwin-Windows10_MSVC2013-Debug-64bits
------------------------------------------------------------------
[...]
877.206sec

@lrineau lrineau changed the title Add timer to see which example is time consuming WIP: Add timer to see which example is time consuming (temporary PR) Dec 3, 2018
@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jan 11, 2019

What should we conclude from the test of this PR?

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jan 18, 2019

@lrineau commented on Jan 11, 2019, 4:46 PM GMT+1:

What should we conclude from the test of this PR?

Ping @afabri! What are the conclusions, and can we close this PR?

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jan 24, 2019

ping again @afabri

@maxGimeno maxGimeno added this to the Trash / Attic milestone Jan 25, 2019
@afabri
Copy link
Copy Markdown
Member Author

afabri commented Jan 29, 2019

We can close the pull request as we now know what takes time. It seems to be related to swapping and we have to work on that.

@lrineau lrineau added Invalid Not a bug and removed Not yet approved The feature or pull-request has not yet been approved. Invalid labels Jan 29, 2019
@lrineau lrineau closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants