WIP: Add timer to see which example is time consuming (temporary PR)#3397
Closed
afabri wants to merge 6 commits intoCGAL:masterfrom
Closed
WIP: Add timer to see which example is time consuming (temporary PR)#3397afabri wants to merge 6 commits intoCGAL:masterfrom
afabri wants to merge 6 commits intoCGAL:masterfrom
Conversation
Member
|
https://travis-ci.org/CGAL/cgal/jobs/440522930#L3477 Please test what you push! |
Member
|
I fixed the compilation errors. And I tested! 2 minutes of my time, and 10 minutes of my computer time... |
0d55e45 to
b7d5071
Compare
Something got wrong in the previous git-rebase.
Member
|
This PR was tested in https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.14-Ic-30/Mesh_3/TestReport_afabri_x64_Cygwin-Windows10_MSVC2013-Debug-64bits.gz Consuming tests: |
Member
|
What should we conclude from the test of this PR? |
Member
|
@lrineau commented on Jan 11, 2019, 4:46 PM GMT+1:
Ping @afabri! What are the conclusions, and can we close this PR? |
Member
|
ping again @afabri |
Member
Author
|
We can close the pull request as we now know what takes time. It seems to be related to swapping and we have to work on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add timer in the Mesh_3 examples to see what takes time in the VC2013 testsuite.
Not really targeted for integration into master.