Skip to content

Testsuite: Integrate some satellite projects #3443

Open
maxGimeno wants to merge 5 commits intoCGAL:mainfrom
maxGimeno:Testsuite-Integrate_satellites_projects-GF
Open

Testsuite: Integrate some satellite projects #3443
maxGimeno wants to merge 5 commits intoCGAL:mainfrom
maxGimeno:Testsuite-Integrate_satellites_projects-GF

Conversation

@maxGimeno
Copy link
Copy Markdown
Contributor

@maxGimeno maxGimeno commented Nov 7, 2018

Modify testsuite scripts to add external projects to the tests if -x is given to autotest_cgal.

Release Management

@maxGimeno
Copy link
Copy Markdown
Contributor Author

maxGimeno commented Nov 7, 2018

For now only SFCGAL is implemented.

@lrineau lrineau self-requested a review November 7, 2018 13:14
@lrineau lrineau added the Not yet approved The feature or pull-request has not yet been approved. label Nov 7, 2018
@lrineau lrineau self-assigned this Nov 7, 2018
@maxGimeno maxGimeno added this to the 4.15-beta milestone Jan 25, 2019
@lrineau lrineau added rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked and removed rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked labels Jan 28, 2019
@lrineau lrineau removed the rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked label Apr 1, 2019
@maxGimeno maxGimeno modified the milestones: 5.0-beta, 5.1-beta Jun 17, 2019
@MaelRL MaelRL changed the base branch from master to releases/CGAL-4.14-branch March 26, 2020 20:01
@MaelRL MaelRL changed the base branch from releases/CGAL-4.14-branch to master March 26, 2020 20:01
@MaelRL MaelRL removed this from the 5.1-beta milestone Apr 7, 2020
@maxGimeno maxGimeno added this to the Trash / Attic milestone Oct 20, 2020
@maxGimeno maxGimeno modified the milestone: Trash / Attic Feb 19, 2021
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Aug 30, 2021

@maxGimeno We should test this one. Could you please refresh it?

@maxGimeno
Copy link
Copy Markdown
Contributor Author

maxGimeno commented Sep 2, 2021

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-42.shtml

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Sep 2, 2021

Successfully tested in cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-42.shtml

That is not really tested: there should be at least one test platform that has TEST_XTERNAL=y.

lrineau
lrineau approved these changes Sep 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@lrineau lrineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Sep 2, 2021

Actually, this PR does not implement the suggestion of #3433. That is a different implementation.

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Sep 2, 2021 •
edited
Loading

Actually, this PR does not implement the suggestion of #3433. That is a different implementation.

The proposal from #3433 was to modify the release creation, to embed a new test directory test/xternal_SFCGAL in the CGAL internal release. Here, that is autotest_cgal that is modified, but autotest_cgal is now barely used: all Linux platform uses Docker container and the test_cgal.py script, and most of the non-Linux platforms uses the script autotest_cgal_with_ctest.

@maxGimeno
Copy link
Copy Markdown
Contributor Author

maxGimeno commented Sep 2, 2021

At the time this was developped, autotest_cgal_with_ctest did not exist.
autotest_cgal is still used in the filter_testsuite, FYI

@maxGimeno
Copy link
Copy Markdown
Contributor Author

maxGimeno commented Sep 3, 2021

Currently installed on Gauguin

@sloriot sloriot added this to the 5.5-beta1 milestone Sep 23, 2021
@MaelRL MaelRL modified the milestones: 5.5-beta, 5.6-beta Mar 28, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 24, 2023
@janetournois janetournois modified the milestones: 6.0-beta, Trash / Attic May 16, 2024
@sloriot sloriot changed the base branch from master to main September 16, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lrineau lrineau lrineau approved these changes

Assignees

@lrineau lrineau

Labels

Not yet approved The feature or pull-request has not yet been approved.

Projects

None yet

Milestone

Trash / Attic

Development

Successfully merging this pull request may close these issues.

Implement satellites projects

5 participants

@maxGimeno @sloriot @lrineau @MaelRL @janetournois