Skip to content

Polyhedron demo: First draft for a WRL plugin#3655

Closed
maxGimeno wants to merge 3 commits intoCGAL:masterfrom
maxGimeno:Polyhedron_IO-WRL_reader-GF
Closed

Polyhedron demo: First draft for a WRL plugin#3655
maxGimeno wants to merge 3 commits intoCGAL:masterfrom
maxGimeno:Polyhedron_IO-WRL_reader-GF

Conversation

@maxGimeno
Copy link
Copy Markdown
Contributor

Summary of Changes

This adds a basic WRL reader to the demo. It won't read a file without a "Shape" keyword, and should be enhanced in the future.

Release Management

  • Affected package(s):Polyhedron_Demo

@maxGimeno maxGimeno force-pushed the Polyhedron_IO-WRL_reader-GF branch from 9acd12f to 7aebc3c Compare February 1, 2019 15:31
@maxGimeno
Copy link
Copy Markdown
Contributor Author

@MaelRL MaelRL modified the milestone: 4.14-beta Feb 7, 2019
@MaelRL
Copy link
Copy Markdown
Member

MaelRL commented Feb 7, 2019

I think it would be best to postpone that to 4.15, Andreas already had some files that couldn't be opened with just this code. (The issue was that the geometry was only put in a single shape, and all the other shapes were just combinatorics; I guess that in that case you're supposed to use the coordinates from the first shape in the other shapes too...)

@lrineau lrineau added the rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked label Feb 7, 2019
@lrineau lrineau added this to the 4.15-beta milestone Feb 7, 2019
@lrineau lrineau removed the rm: not for next release Indicate to the release team that a PR should not be merged before the next release branch is forked label Apr 1, 2019
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Apr 12, 2019

@MaelRL @afabri do you have an updated version of the reader that could be contributed here?

@MaelRL
Copy link
Copy Markdown
Member

MaelRL commented Apr 12, 2019

As of now, no.

@lrineau
Copy link
Copy Markdown
Member

lrineau commented Jun 20, 2019

Do we want to close this pull-request? It seems the current code is not good enough:

@MaelRL commented on Feb 7, 2019, 10:25 AM GMT+1:

I think it would be best to postpone that to 4.15, Andreas already had some files that couldn't be opened with just this code. (The issue was that the geometry was only put in a single shape, and all the other shapes were just combinatorics; I guess that in that case you're supposed to use the coordinates from the first shape in the other shapes too...)

@MaelRL MaelRL added the CGAL I/O label Feb 3, 2020
@MaelRL MaelRL modified the milestones: 5.1-beta, 5-2-beta Apr 7, 2020
@MaelRL MaelRL modified the milestones: 5.2-beta, 5.3-beta Oct 14, 2020
@maxGimeno maxGimeno modified the milestones: 5.3-beta, Trash / Attic Mar 3, 2021
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Aug 30, 2021

Closing it. We will reopen/finish it if we need to.

@sloriot sloriot closed this Aug 30, 2021
@sloriot sloriot deleted the Polyhedron_IO-WRL_reader-GF branch August 30, 2021 08:09
@sloriot sloriot restored the Polyhedron_IO-WRL_reader-GF branch August 30, 2021 08:09
@MaelRL MaelRL removed the Conflicts label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants